Skip to content

Adjust redirect page design #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Dec 4, 2018
Merged

Adjust redirect page design #1185

ChristophWurst merged 1 commit into from
Dec 4, 2018

Conversation

@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Oct 2, 2018 •
edited by ChristophWurst
Loading

Redirect of Mail app before & after, had no hover/focus effect either. General style adjusted like the modal in nextcloud/server#11536
screenshot from 2018-10-02 20-45-48
screenshot from 2018-10-02 20-38-44

@jancborchardt
Adjust redirect page design
38603b8 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member Author

jancborchardt commented Oct 18, 2018

@ChristophWurst the blocker nextcloud/server#11557 was merged, can you check again? :)

@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 18, 2018

The block is that this requires Nextcloud 15:

mail/appinfo/info.xml

Line 25 in 8a2f8f3

<nextcloud min-version="14" max-version="15" />

ChristophWurst
ChristophWurst approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChristophWurst ChristophWurst merged commit 8c887d3 into master Dec 4, 2018
@ChristophWurst ChristophWurst deleted the redirect-design branch December 4, 2018 09:08
@jancborchardt
Copy link
Member Author

jancborchardt commented Dec 4, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kevgathuku kevgathuku Awaiting requested review from kevgathuku

Assignees

No one assigned

Labels

3. to review bug design

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jancborchardt @ChristophWurst