Skip to content

Conversation

@jancborchardt
Copy link
Member

Fixed mail subtitle

mail subtitle before
mail header after

Fixed mail composer borders

mail composer borders before
composer borders after

Tried to fix folder icons

But for some reason inbox, favorites, and trash are not replaced. Any idea why @skjnldsv?
mail folder icons before mail icons after

Please review @nextcloud/mail :)

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@MorrisJobke
Copy link
Member

Merge?

@ChristophWurst
Copy link
Member

Sure! I guess the folder icon fix can happen later :)

@ChristophWurst ChristophWurst merged commit 9ca6436 into master Jan 18, 2019
@ChristophWurst ChristophWurst deleted the darktheme-fixes branch January 18, 2019 08:43
@jancborchardt
Copy link
Member Author

About the folder icons which are not inverted, @skjnldsv said to me:

Maybe the parser has issues checking the icon?
You can try the regex in the iconsCacher.php file
and your svg
with regex101.com

@ChristophWurst does that help? :)

@ChristophWurst
Copy link
Member

I have no clue about the icons 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants