Skip to content

Conversation

@ChristophWurst
Copy link
Member

fixes #207.
Probably caused by #126.

@jancborchardt @tahaalibra @nextcloud/mail please test

Steps to reproduce:

  1. set up app
  2. run 'make optimize-js'
  3. disable debug mode
  4. view app in the browser

@jancborchardt
Copy link
Member

Instantly makes it work again 👍 🎉 !

However some console errors, maybe unrelated:

/nextcloud/remote.php/dav/addressbooks/users/jan/contacts/385c868c-aaa0-4bc1-9c03-816b08869d18.vcf?photo:1 GET http://localhorst/nextcloud/remote.php/dav/addressbooks/users/jan/contacts/385c868c-aaa0-4bc1-9c03-816b08869d18.vcf?photo net::ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION
/nextcloud/remote.php/dav/addressbooks/users/jan/contacts/cd5a2c8d-4cbd-4c70-9ff4-52c9bb4a2d65.vcf?photo:1 GET http://localhorst/nextcloud/remote.php/dav/addressbooks/users/jan/contacts/cd5a2c8d-4cbd-4c70-9ff4-52c9bb4a2d65.vcf?photo net::ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION
mail.min.js?v=5e2306a…:153 Uncaught TypeError: Cannot read property 'currentView' of undefined

@jancborchardt
Copy link
Member

Ah yep – it breaks avatars :)

@ChristophWurst
Copy link
Member Author

mail.min.js?v=5e2306a…:153 Uncaught TypeError: Cannot read property 'currentView' of undefined

Fix is included in #90.

Ah yep – it breaks avatars :)

They they work before? Works with current nc master here.

@jancborchardt
Copy link
Member

Ok then let’s merge it for now cause it fixes the main issue right now. :) Maybe it’s just a checkout bug or other thing.

@jancborchardt jancborchardt merged commit ea27d35 into master Dec 5, 2016
@jancborchardt jancborchardt deleted the js-main-module branch December 5, 2016 11:57
@lock
Copy link

lock bot commented Nov 21, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions.

@lock lock bot locked and limited conversation to collaborators Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App doesn’t load

3 participants