fix full mail visibility on mobile #2218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Run npm run lint:autofix :)
GretaD
force-pushed
the
bugfix/1740/fix_visibility_mobile
branch
3 times, most recently
from
02e44f1 to
e07188f
Compare
Member
Try again 🙊 |
Signed-off-by: Greta Doci <gretadoci@gmail.com>
GretaD
force-pushed
the
bugfix/1740/fix_visibility_mobile
branch
from
e07188f to
9c66323
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Member
|
@GretaD and @violoncelloCH did you coordinate on this then? Is this PR or #2222 going to be used going forward? :) |
Member
|
as also discussed with @juliushaertl and @skjnldsv the pure css approach in #2222 seems to be the better way to do this (less performance heavy as it just uses css flex) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1740