Skip to content

Feature/noissue/plain text vs rich text checkbox #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Nov 12, 2019
Merged

Feature/noissue/plain text vs rich text checkbox #2247

ChristophWurst merged 1 commit into from
Nov 12, 2019

Conversation

@violoncelloCH
Copy link
Member

@violoncelloCH violoncelloCH commented Nov 12, 2019 •
edited
Loading

this is a followup PR to #2226
as discussed there I've split this change into a separate PR

@violoncelloCH violoncelloCH force-pushed the feature/noissue/plain-text-vs-rich-text-checkbox branch from ba7e014 to c405791 Compare November 12, 2019 16:19
@violoncelloCH violoncelloCH added 3. to review design enhancement feature:editor All bugs, features and pull requests about the (HTML) editor and removed 2. developing blocked labels Nov 12, 2019
ChristophWurst
ChristophWurst approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also be fine with Enable formatting and Disable formatting. It's clear that this is about text

@violoncelloCH
👌 IMPROVE: use simpler wording for rich-text/plain-text checkbox
07af60c 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
@violoncelloCH violoncelloCH force-pushed the feature/noissue/plain-text-vs-rich-text-checkbox branch from c405791 to 07af60c Compare November 12, 2019 20:26
@violoncelloCH
Copy link
Member Author

violoncelloCH commented Nov 12, 2019

makes sense! - changed that...

@ChristophWurst ChristophWurst merged commit 805bf3f into master Nov 12, 2019
@ChristophWurst ChristophWurst deleted the feature/noissue/plain-text-vs-rich-text-checkbox branch November 12, 2019 21:39
@ChristophWurst ChristophWurst added this to the 0.19.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

No one assigned

Labels

4. to release design enhancement feature:editor All bugs, features and pull requests about the (HTML) editor

Projects

None yet

Milestone

0.19.0

Development

Successfully merging this pull request may close these issues.

3 participants

@violoncelloCH @ChristophWurst