Skip to content

Fit nextcloud css guidelines #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Jan 13, 2017
Merged

Fit nextcloud css guidelines #278

ChristophWurst merged 1 commit into from
Jan 13, 2017

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 11, 2017

Should probably be best with the last fix from nextcloud/server#3024

@skjnldsv skjnldsv self-assigned this Jan 11, 2017
ChristophWurst
ChristophWurst reviewed Jan 12, 2017
View reviewed changes
js/templates/account.html
<div class="app-navigation-entry-menu">
<ul>
<li><button class="icon-rename svg" title="{{ t 'Settings' }}"></button></li>
</ul>
Copy link
Member

@ChristophWurst ChristophWurst Jan 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Member Author

@skjnldsv skjnldsv Jan 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member

@ChristophWurst ChristophWurst Jan 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know why we had two list there

Copy link
Member Author

@skjnldsv skjnldsv Jan 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 12, 2017

bildschirmfoto von 2017-01-12 09-41-39
looks strange on FF

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 12, 2017

@ChristophWurst do you mean the scrollbar?

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 12, 2017

yes ;-)

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 12, 2017

Well it isn't related to this pr ^^
And the firefox scrollbar has always been awful 😱
capture d ecran_2017-01-12_13-52-08

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 12, 2017

Well it isn't related to this pr ^^

will check again later. IIRC that little scrollbar just scrolls the three dots, not the entire list of accounts/folders.

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 12, 2017

Still the same issue when I'm on nextcloud/server#3024 and this PR's branch:
bildschirmfoto von 2017-01-12 23-02-36

@skjnldsv
Fit nextcloud css guidelines
83d078b 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 13, 2017

Fixed.

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 13, 2017

@skjnldsv which server branch did you use to test this? On master it works, but in combination with nextcloud/server#3024 I still get the scroll bar :-/

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 13, 2017 •
edited
Loading

@ChristophWurst the last update commit of this pr: 83d078b
with the latest nextcloud/server#3024 at nextcloud/server@ce9c833 Sorry I forgot to push 😞

ChristophWurst
ChristophWurst approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it looks good :-D

@ChristophWurst ChristophWurst merged commit ce7f46f into master Jan 13, 2017
@ChristophWurst ChristophWurst deleted the fix-app-navigation branch January 13, 2017 15:26
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 13, 2017

😆

@lock
Copy link

lock bot commented Nov 21, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions.

@lock lock bot locked and limited conversation to collaborators Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@skjnldsv skjnldsv

Labels

3. to review design

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @ChristophWurst