add text to email account menu #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Added a screenshot above, now easier to review. :) |
Member
Author
|
Easy review, please check this out @nextcloud/mail :) |
| deleteButton: 'button[class^="icon-delete"]', | ||
| settingsButton: 'button[class^="icon-rename"]' | ||
| menu: '.app-navigation-entry-menu', | ||
| settingsButton: '.action-settings', |
Member
There was a problem hiding this comment.
doesn't this change mean that clicking the text has no effect? Only the icon will have a click handler registered now.
Member
Author
There was a problem hiding this comment.
Nope, because .action-settings is the whole a element which spans the full width. ;)
js/templates/account.html
Outdated
| </div> | ||
| {{/if}} | ||
|
|
||
|
|
Member
|
@jancborchardt ping 😉 |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
force-pushed
the
menu-icons
branch
from
b1dfe11 to
996776a
Compare
Member
Author
|
Addressed your concerns and rebased to master. :) |
ChristophWurst
approved these changes
Apr 24, 2017
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
CI failure seems unrelated -> can be merged IMO
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check out the 3-dot menu of the mail account :) now has text next to the icons like all other menus in Nextcloud.
Please review @nextcloud/mail @nextcloud/designers