Skip to content

Test against nc 23 #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GretaD merged 1 commit into from
Jun 25, 2021
Merged

Test against nc 23 #5229

GretaD merged 1 commit into from
Jun 25, 2021

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Jun 24, 2021 •
edited
Loading

thats all i need to change, right?

@GretaD GretaD added this to the v1.10.0 milestone Jun 24, 2021
@GretaD GretaD requested a review from ChristophWurst June 24, 2021 11:39
@GretaD GretaD self-assigned this Jun 24, 2021
@ChristophWurst ChristophWurst changed the title Test against nc 22 Test against nc 23 Jun 24, 2021
ChristophWurst
ChristophWurst reviewed Jun 24, 2021
View reviewed changes
@GretaD GretaD force-pushed the enhancement/nc_23_compatibility branch from 0bf8f1c to e33fc31 Compare June 24, 2021 11:46
@GretaD GretaD requested a review from ChristophWurst June 24, 2021 11:47
@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 24, 2021

info.xml doesn't allow 23 yet

@GretaD
Copy link
Contributor Author

GretaD commented Jun 24, 2021

info.xml doesn't allow 23 yet

because i need to change this: https://github.com/nextcloud/mail/blob/master/appinfo/info.xml#L37
to 23, right?

@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 24, 2021

because i need to change this: https://github.com/nextcloud/mail/blob/master/appinfo/info.xml#L37
to 23, right?

yes. That will bite us as soon as they've updated https://github.com/nextcloud/server/blob/4e9727037220a8acddf7a3478a047c0bc6fc4bae/version.php#L33 to say 23

@GretaD
Copy link
Contributor Author

GretaD commented Jun 24, 2021

i see Joas pushed #5232 and #5230

@ChristophWurst ChristophWurst modified the milestones: v1.10.0, v1.11.0 Jun 25, 2021
@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 25, 2021

i see Joas pushed #5232 and #5230

Rebase to see what is left. I think your changes on the CI matrix are still required :)

@GretaD GretaD force-pushed the enhancement/nc_23_compatibility branch from b056eff to 998f71f Compare June 25, 2021 12:26
@GretaD
Test against nc 22
5c09c89 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD force-pushed the enhancement/nc_23_compatibility branch from 998f71f to 5c09c89 Compare June 25, 2021 12:30
@GretaD GretaD merged commit debeaeb into master Jun 25, 2021
@GretaD GretaD deleted the enhancement/nc_23_compatibility branch June 25, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@GretaD GretaD

Labels

3. to review enhancement

Projects

None yet

Milestone

v1.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@GretaD @ChristophWurst