Clean up navigation views #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
changed the title
ChristophWurst
commented
Oct 30, 2017
| folders: '.folders' | ||
| folders: { | ||
| el: '.folders', | ||
| replaceElement: true |
Member
Author
There was a problem hiding this comment.
@skjnldsv FYI this remove one of the wrapping elements
ChristophWurst
commented
Oct 30, 2017
| accounts: '#app-navigation-accounts', | ||
| accounts: { | ||
| el: '#app-navigation-accounts', | ||
| replaceElement: true |
skjnldsv
approved these changes
Oct 30, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanups, originally written to replace #521 but no valid solution was found. IMO still an improvement and thus I would like to integrate this.