Skip to content

Fix CSS in app-navigation #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 7 commits into from
Nov 2, 2017
Merged

Fix CSS in app-navigation #594

ChristophWurst merged 7 commits into from
Nov 2, 2017

Conversation

@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Nov 2, 2017 •
edited
Loading

This is pretty much done now! Needs some testing with subfolders @nextcloud/mail

TODO where I need JS help:

  • Don’t show the counter when there are 0 unread mails
  • Fix popover position for account settings
  • Clicking »Show all folders« and collapse should not reload the main content

screenshot from 2017-11-02 17-26-18

@jancborchardt
Remove specific CSS modifications
dff76cb 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added this to the 0.7.5 milestone Nov 2, 2017
@jancborchardt jancborchardt changed the title Remove specific CSS modifications Fix CSS in app-navigation Nov 2, 2017
@jancborchardt
Move from CSS to SCSS
89749ab 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
First usable state
3934b77 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Fix bullet circle and collapse entry
30a2c8c 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Add some whitespace between different accounts
e185316 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 2, 2017

Clicking »Show all folders« and collapse should not reload the main content

Wild guess: did you somehow break the click handler binding and the app tries to navigate to #?

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 2, 2017

Don’t show the counter when there are 0 unread mails

Easy, I can do that. Doesn't have to be in this PR as that's independent.

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 2, 2017

Fix popover position for account settings

Why do we need js for this?

ChristophWurst
ChristophWurst previously requested changes Nov 2, 2017
View reviewed changes
js/templates/account.html Outdated
{{#if hasFolders}}
<li class="account-toggle-collapse">{{toggleCollapseMessage}}</li>
<li class="account-toggle-collapse">
<a href="">{{toggleCollapseMessage}}</a>
Copy link
Member

@ChristophWurst ChristophWurst Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you go. The newly added a element causes an unexpected navigation. The click handler should call event.preventDefault().

Copy link
Member

@skjnldsv skjnldsv Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preventDefault isn't working here, wefound something else. ;)

@jancborchardt
Fix popover position
642b985 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Fix reload of content on collapse/expand
ef1b796 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member Author

jancborchardt commented Nov 2, 2017

Pushed a fix for the other two issues, the position was indeed CSS only. :)

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 2, 2017

❤️

@ChristophWurst ChristophWurst merged commit 6afb1ec into master Nov 2, 2017
@ChristophWurst ChristophWurst deleted the app-navigation-css branch November 2, 2017 16:57
@jancborchardt jancborchardt mentioned this pull request Nov 2, 2017
Closed
@ChristophWurst ChristophWurst mentioned this pull request Nov 2, 2017
Closed
@skjnldsv skjnldsv mentioned this pull request Dec 19, 2017
Closed
@lock
Copy link

lock bot commented Nov 20, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions.

@lock lock bot locked and limited conversation to collaborators Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst left review comments

@Gomez Gomez Awaiting requested review from Gomez

Assignees

No one assigned

Labels

2. developing bug design help wanted

Projects

None yet

Milestone

0.7.5

Development

Successfully merging this pull request may close these issues.

4 participants

@jancborchardt @ChristophWurst @skjnldsv