OCC scan failed because of few encrypted files

[AykutCevik]

Hello,

I understand that the file scan is not able to work with encrypted files. Now I have a scenario where the main part of the files are not encrypted and a few of them are (due to changing the encryption, sharing and disabling the encryption).

Running ./occ maps:scan-photos processes the files until it locates the first file which is encrypted and then stops to continue the work:

In Encryption.php line 376:
                                                                                                                      
  Can not decrypt this file, probably this is a shared file. Please ask the file owner to reshare the file with you. 

I would like to suggest just to skip encrypted files and not crash the execution at all. Right now, the process is not able to end its work properly.

Opening the maps-app on Nextcloud tells me that the process isn't finished yet.

Also, is there a workaround for now?

[jancborchardt]

Skipping encrypted files seems to be the best solution indeed.

cc @eneiluj @tacruc @aszlig @Galbar anyone up for fixing this? :)

[tacruc]

I think, we have some problems that corrupted or unexpected files crash the scanning or memory leaks in the used libraries add up. I think a fix for both issues would be to some how start one php task for each photo. @eneiluj what do you think? Any Idea how to implement this?

[XeonG]

Anyway way this could have the arg option to work on encrypted files with addition password for decryption?

[AykutCevik]

When can we expect such a feature @jancborchardt ?

[matiasdelellis]

We had a similar problem with the facerecognition application.. Next clode is magic!! 😅

https://github.com/nextcloud/server/blob/12bdb95c1a40170652570decef7f466e4b97aa65/lib/private/Preview/ProviderV2.php#L81-L98

It also works with shared files, but you must be careful because the only way to solve it is to obtain a local copy of the files. 😉

[jknockaert]

With encryption enabled, it seems like the background job does a decent job in scanning unencrypted files, probablt s a result of #232. But ./occ maps:scan-photos still does not scan unencrypted files and simply exits when it finds the encryption enabled setting.
@tacruc Wouldn't it make sense to also update ./occ maps:scan-photos to evaluate encryption on a file-by-file base rather than using the server-wide encryption setting?