UpdatePhotoByFileJob: Call to a member function getUserFolder() on null

[Githopp192]

Steps to reproduce

Cronjob properly configured as apache user

*/15 * * * * /bin/php -f /var/www/html/nextcloud/cron.php

Run this job manually, will not bring Nextcloud to report, "ok, cron job did run"

Expected behaviour

Nextcloud should be aware,that this job did run previously

Actual behaviour

Nextcloud is reporting that now cron.php did run previously, which is not correct (php.cron job did run)

This behave is since NC Upgr. from 16.0.6 to 16.0.7

Server configuration detail

Operating system: Linux 3.10.0-1062.9.1.el7.x86_64 nextcloud/server#1 SMP Fri Dec 6 15:49:49 UTC 2019 x86_64

Webserver: Apache (apache2handler)

Database: mysql 5.5.64

PHP version:

7.2.24
Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, session, standard, apache2handler, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, intl, json, ldap, exif, mysqlnd, PDO, Phar, posix, shmop, SimpleXML, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlwriter, xsl, zip, mysqli, pdo_mysql, pdo_sqlite, wddx, xmlreader, apcu, igbinary, imagick, redis, Zend OPcache

Nextcloud version: 16.0.7 - 16.0.7.1

Updated from an older Nextcloud/ownCloud or fresh install:

Where did you install Nextcloud from: unknown

Signing status

Array
(
)

List of activated apps

Enabled:
 - accessibility: 1.2.0
 - activity: 2.9.1
 - analytics: 1.2.2
 - announcementcenter: 3.5.1
 - apporder: 0.9.0
 - audioplayer: 2.9.0
 - bookmarks: 2.3.4
 - bruteforcesettings: 1.5.0
 - calendar: 1.7.2
 - circles: 0.17.10
 - cloud_federation_api: 0.2.0
 - comments: 1.6.0
 - contacts: 3.1.8
 - cookbook: 0.5.7
 - cospend: 0.1.0
 - dashboardcharts: 0.1.3
 - data_request: 1.3.0
 - dav: 1.9.2
 - deck: 0.6.6
 - dicomviewer: 1.2.1
 - drawio: 0.9.4
 - drop_account: 0.1.0
 - event_update_notification: 0.3.4
 - extract: 1.2.3
 - federatedfilesharing: 1.6.0
 - federation: 1.6.0
 - files: 1.11.0
 - files_antivirus: 2.2.1
 - files_downloadactivity: 1.5.0
 - files_ebookreader: 0.0.1
 - files_mindmap: 0.0.15
 - files_pdfviewer: 1.5.0
 - files_rightclick: 0.15.1
 - files_sharing: 1.8.0
 - files_texteditor: 2.8.0
 - files_trashbin: 1.6.0
 - files_versions: 1.9.0
 - files_videoplayer: 1.5.0
 - firstrunwizard: 2.5.0
 - flowupload: 0.1.8
 - gallery: 18.3.0
 - issuetemplate: 0.6.0
 - joplin: 0.0.25
 - logreader: 2.1.0
 - lookup_server_connector: 1.4.0
 - maps: 0.1.4
 - nextcloud_announcements: 1.5.0
 - notes: 3.1.1
 - notifications: 2.4.1
 - oauth2: 1.4.2
 - onlyoffice: 4.1.4
 - ownbackup: 19.9.0
 - passman: 2.3.4
 - password_policy: 1.6.0
 - polls: 1.1.6
 - privacy: 1.0.0
 - provisioning_api: 1.6.0
 - quicknotes: 0.2.2
 - quota_warning: 1.5.0
 - radio: 0.6.5
 - rainloop: 6.0.6
 - ransomware_protection: 1.4.1
 - recommendations: 0.4.0
 - serverinfo: 1.6.0
 - sharebymail: 1.6.0
 - sharerenamer: 2.7.3
 - socialsharing_diaspora: 1.0.5
 - socialsharing_email: 1.0.6
 - socialsharing_facebook: 1.0.5
 - socialsharing_googleplus: 1.0.4
 - socialsharing_twitter: 1.0.5
 - spreed: 6.0.4
 - support: 1.0.0
 - suspicious_login: 1.0.0
 - systemtags: 1.6.0
 - tasks: 0.11.3
 - terms_of_service: 1.2.3
 - theming: 1.7.0
 - twofactor_backupcodes: 1.5.0
 - twofactor_totp: 3.0.1
 - updatenotification: 1.6.0
 - viewer: 1.2.0
 - workflowengine: 1.6.0
Disabled:
 - admin_audit
 - carnet
 - dashboard
 - encryption
 - external
 - files_accesscontrol
 - files_external
 - files_fulltextsearch
 - files_markdown
 - fulltextsearch
 - fulltextsearch_elasticsearch
 - impersonate
 - jsloader
 - passwords
 - richdocuments
 - survey_client
 - user_ldap
 - weather

Configuration (config/config.php)

{
    "memcache.local": "\\OC\\Memcache\\APCu",
    "filelocking.enabled": true,
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "port": 0,
        "dbindex": 0,
        "timeout": 1.5
    },
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        xxx
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "overwrite.cli.url": "https:\/\/xxxx",
    "htaccess.RewriteBase": "\/",
    "overwriteprotocol": "https",
    "dbtype": "mysql",
    "version": "16.0.7.1",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "maintenance": false,
    "theme": "",
    "loglevel": 1,
    "updater.release.channel": "production",
    "auth.bruteforce.protection.enabled": true,
    "check_for_working_htaccess": true,
    "data-fingerprint": "xxxxxx",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpmode": "smtp",
    "mail_smtpauthtype": "LOGIN",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpsecure": "tls",
    "mail_smtpauth": 1,
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpport": "587",
    "session_lifetime": 1200,
    "session_keepalive": false,
    "logtimezone": "Europe\/xxxx",
    "logfile": "\/media\/log\/nextcloud.log",
    "knowledgebaseenabled": false,
    "log_rotate_size": 3145728,
    "onlyoffice": {
        "verify_peer_off": true
    },
    "mail_sendmailmode": "smtp"
}

Are you using external storage, if yes which one: no..

Are you using encryption: false

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36

Operating system: Windows 10

Logs

Web server error log

Insert your web server log here 

Nextcloud log

[cron] Error: Error: Call to a member function getUserFolder() on null at <>

0. /var/www/html/nextcloud/lib/public/BackgroundJob/Job.php line 77
   OCA\Maps\BackgroundJob\UpdatePhotoByFileJob->run({fileId: 1100436,userId: "Michael"})
1. /var/www/html/nextcloud/lib/public/BackgroundJob/QueuedJob.php line 46
   OCP\BackgroundJob\Job->execute(OC\BackgroundJob\JobList {}, OC\Log {})
2. /var/www/html/nextcloud/cron.php line 123
   OCP\BackgroundJob\QueuedJob->execute(OC\BackgroundJob\JobList {}, OC\Log {})

at 2020-01-30T17:49:59+01:00

[kesselb]

Nextcloud is reporting that now cron.php did run previously, which is not correct (php.cron job did run)

Yes and No. cron.php crashed so the information seems to be valid.

[kesselb]

https://github.com/nextcloud/server/blob/9ed106f69acaf419414dccfcfd7efa6de22aa45a/lib/private/BackgroundJob/Job.php#L66

cc @rullzer @ChristophWurst should we use \Throwable to catch those errors too?

[rullzer]

https://github.com/nextcloud/server/blob/9ed106f69acaf419414dccfcfd7efa6de22aa45a/lib/private/BackgroundJob/Job.php#L66

cc @rullzer @ChristophWurst should we use \Throwable to catch those errors too?

Probably yes
mind to shoot in a PR?

[Githopp192]

did several checks over the last couple of days .. same result ..
Now .. one minute ago .. i did the check again. Now all checks passed -->

Strange .. the only thing i did just before .. was update the App "FullTextSearch" .. don't think has something to do with that ..

[Githopp192]

[Githopp192]

some background information .. don't know .. if they may have some side effects, regarding the cron.php Job .. when upgrading the NC .. NC .. as i read will start some (probably demanding sub-tasks, like file scan ..).

Per default - when upgrading the NC .. i will also patch the OS and restart the VM. When doing so some demanding centos daemons are starting .. like LSYNCD .. this is some kind of a live synchronization tool .. which is depending on a /etc/sysctl.conf Configuration --> fs.inotify.max_user_watches=210000; this parameter has to do with the LSYNCD Daemon, which needs to watch all files on the Server (including the NC-Data Folder); and this service will start from scratch when VM is booting and may use a lot of ressources .. ?!

On the other hand .. i did not see any kernel low memory messages or something like that into the syslog.

[Githopp192]

[cron] Error: Error: Call to a member function getUserFolder() on null at <>

0. /var/www/html/nextcloud/lib/public/BackgroundJob/Job.php line 77
   OCA\Maps\BackgroundJob\UpdatePhotoByFileJob->run({fileId: 1229639,userId: "DomSchuler"})
1. /var/www/html/nextcloud/lib/public/BackgroundJob/QueuedJob.php line 46
   OCP\BackgroundJob\Job->execute(OC\BackgroundJob\JobList {}, OC\Log {})
2. /var/www/html/nextcloud/cron.php line 123
   OCP\BackgroundJob\QueuedJob->execute(OC\BackgroundJob\JobList {}, OC\Log {})

at 2020-02-01T14:00:04+01:00

[Githopp192]

error re-appeared

some other jobs-related messages -->

[PHP] Error: Undefined property: OCA\Maps\BackgroundJob\UpdatePhotoByFileJob::$root at /var/www/html/nextcloud/apps/maps/lib/BackgroundJob/UpdatePhotoByFileJob.php#43

at 2020-02-01T14:00:04+01:00

[kesselb]

I would suggest to uninstall the maps app and wait for a patch.

[tacruc]

Duplicate #247 #251 should fix it