Unsupported operand types: int * string in /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelIfd.php:447

[GHJester]

Hi all,

Nextcloud is running in a docker container on my host. Recently I updated to version 22.1.1. Maps is running with version 0.1.9. Today I checked for another update and have seen that the last cron job execution was 6 days ago, even though I configured to run every 5 minutes.
When I execute the cron job manually by executing docker exec -u www-data nextcloud php cron.php, I get the following error output:

TypeError: Unsupported operand types: int * string in /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelIfd.php:447
Stack trace:
#0 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelCanonMakerNotes.php(215): lsolesen\pel\PelIfd->loadSingleValue(Object(lsolesen\pel\PelDataWindow), 4776, 0, 256)
#1 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelIfd.php(406): lsolesen\pel\PelCanonMakerNotes->load()
#2 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelTiff.php(159): lsolesen\pel\PelIfd->load(Object(lsolesen\pel\PelDataWindow), 10)
#3 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelExif.php(108): lsolesen\pel\PelTiff->load(Object(lsolesen\pel\PelDataWindow))
#4 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelJpeg.php(216): lsolesen\pel\PelExif->load(Object(lsolesen\pel\PelDataWindow))
#5 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelJpeg.php(126): lsolesen\pel\PelJpeg->load(Object(lsolesen\pel\PelDataWindow))
#6 /var/www/html/custom_apps/maps/lib/Service/PhotofilesService.php(442): lsolesen\pel\PelJpeg->__construct(Object(lsolesen\pel\PelDataWindow))
#7 /var/www/html/custom_apps/maps/lib/Service/PhotofilesService.php(384): OCA\Maps\Service\PhotofilesService->getExifPelBackup(Object(OC\Files\Node\File))
#8 /var/www/html/custom_apps/maps/lib/Service/PhotofilesService.php(264): OCA\Maps\Service\PhotofilesService->getExif(Object(OC\Files\Node\File))
#9 /var/www/html/custom_apps/maps/lib/BackgroundJob/AddPhotoJob.php(56): OCA\Maps\Service\PhotofilesService->addPhotoNow(Object(OC\Files\Node\File), 'XXXXX')
#10 /var/www/html/lib/public/BackgroundJob/Job.php(79): OCA\Maps\BackgroundJob\AddPhotoJob->run(Array)
#11 /var/www/html/lib/public/BackgroundJob/QueuedJob.php(47): OCP\BackgroundJob\Job->execute(Object(OC\BackgroundJob\JobList), Object(OC\Log))
#12 /var/www/html/cron.php(127): OCP\BackgroundJob\QueuedJob->execute(Object(OC\BackgroundJob\JobList), Object(OC\Log))
#13 {main}

1. This seems for me to be related to A non-numeric value encountered at /var/www/nextcloud/apps/maps/vendor/lsolesen/pel/src/PelIfd.php#447 pel/pel#156. But this issue is already fixed.
2. As far as I understood Nexcloud 22.1.1 has been upgraded to use PHP 8. This explains the different message Unsupported operand types: int * string
3. I think I need to mention that I uploaded a bulk of very old photos to my Nextcloud instance a few days ago. It is very likely that one of them caused that issue. But I don't have any clue how to figure out. But as 1. has been fixed in 2020 I assume that Maps is still using an old version of pel!?

Do you have an idea how to fix or is there something I can change?

Cheers
Jester

[klaHoadl]

I changed line 447 and casted the return value from getSize() to int

$s = (int) PelFormat::getSize($format) * $components;

[GHJester]

@klaHoadl thx for your help. In the meantime I upgraded to 22.2.0 and the error is gone (for what reason ever). But is seems like that now everything is messed up. In the past I have seen the photo locations on the map, but now I don't see a single photo and its location on the world map anymore.

EDIT: wow, now, after the proposed fix, the photos are displayed and back to normal. thx for your support! :)

[Niemand112233]

There is also an error in line 611.

Edit: Update of PHP 8.0 seemed to solve the error

[GHJester]

Something is still weird. There are only around 900 photos displayed, though I have more than 10.000. This definitely needs a fix...

[elearningdienst]

Same problem here with PHP 8.0.12 and Nextcloud 22.2.2 (map version 0.1.9).

[arthurlt]

I'm having a similar issue running Nextcloud's Docker build.

PHP 8.0.13
Nextcloud 22.2.3
Maps 0.1.9

[citramon]

I have a similar issue.

Docker build.
PHP 8.0.12
Nextcloud 22.2.0
Maps 0.1.9.

I think the problem in other package with same types of files.
I fix it in this file:

                case PelTag::CANON_CUSTOM_FUNCTIONS:
                    //TODO
                case (256 || 512 || 768):
                    break;
                    //SKIP BECAUSE EXCEPTION
                default:

The idea is skip files which rise exception 🤷‍♂️

[kamilkobak]

I have the same problem

[DeniGam]

Thesame error blocks cron job ececution:

TypeError: Unsupported operand types: int * string in /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelIfd.php:447 Stack trace: #0 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelCanonMakerNotes.php(215): lsolesen\pel\PelIfd->loadSingleValue(Object(lsolesen\pel\PelDataWindow), 4906, 0, 256) #1 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelIfd.php(406): lsolesen\pel\PelCanonMakerNotes->load() #2 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelTiff.php(159): lsolesen\pel\PelIfd->load(Object(lsolesen\pel\PelDataWindow), 10) #3 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelExif.php(108): lsolesen\pel\PelTiff->load(Object(lsolesen\pel\PelDataWindow)) #4 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelJpeg.php(216): lsolesen\pel\PelExif->load(Object(lsolesen\pel\PelDataWindow)) #5 /var/www/html/custom_apps/maps/vendor/lsolesen/pel/src/PelJpeg.php(126): lsolesen\pel\PelJpeg->load(Object(lsolesen\pel\PelDataWindow)) #6 /var/www/html/custom_apps/maps/lib/Service/PhotofilesService.php(442): lsolesen\pel\PelJpeg->__construct(Object(lsolesen\pel\PelDataWindow)) #7 /var/www/html/custom_apps/maps/lib/Service/PhotofilesService.php(384): OCA\Maps\Service\PhotofilesService->getExifPelBackup(Object(OC\Files\Node\File)) #8 /var/www/html/custom_apps/maps/lib/Service/PhotofilesService.php(264): OCA\Maps\Service\PhotofilesService->getExif(Object(OC\Files\Node\File)) #9 /var/www/html/custom_apps/maps/lib/BackgroundJob/AddPhotoJob.php(56): OCA\Maps\Service\PhotofilesService->addPhotoNow(Object(OC\Files\Node\File), 'kroshe4ka.m') #10 /var/www/html/lib/public/BackgroundJob/Job.php(79): OCA\Maps\BackgroundJob\AddPhotoJob->run(Array) #11 /var/www/html/lib/public/BackgroundJob/QueuedJob.php(47): OCP\BackgroundJob\Job->execute(Object(OC\BackgroundJob\JobList), Object(OC\Log)) #12 /var/www/html/cron.php(128): OCP\BackgroundJob\QueuedJob->execute(Object(OC\BackgroundJob\JobList), Object(OC\Log)) #13 {main}
NC version 23.0.0.10

[heminei]

I have the same error:

{
   "reqId":"",
   "level":3,
   "time":"2022-01-04T16:10:02+00:00",
   "remoteAddr":"",
   "user":"--",
   "app":"cron",
   "method":"",
   "url":"--",
   "message":"Unsupported operand types: int * string",
   "userAgent":"--",
   "version":"23.0.0.10",
   "exception":{
      "Exception":"TypeError",
      "Message":"Unsupported operand types: int * string",
      "Code":0,
      "Trace":[
         {
            "file":"/apps/maps/vendor/lsolesen/pel/src/PelIfd.php",
            "line":368,
            "function":"loadSingleValue",
            "class":"lsolesen\\pel\\PelIfd",
            "type":"->"
         },
         {
            "file":"/apps/maps/vendor/lsolesen/pel/src/PelIfd.php",
            "line":350,
            "function":"load",
            "class":"lsolesen\\pel\\PelIfd",
            "type":"->"
         },
         {
            "file":"/apps/maps/vendor/lsolesen/pel/src/PelTiff.php",
            "line":159,
            "function":"load",
            "class":"lsolesen\\pel\\PelIfd",
            "type":"->"
         },
         {
            "file":"/apps/maps/vendor/lsolesen/pel/src/PelExif.php",
            "line":108,
            "function":"load",
            "class":"lsolesen\\pel\\PelTiff",
            "type":"->"
         },
         {
            "file":"/apps/maps/vendor/lsolesen/pel/src/PelJpeg.php",
            "line":216,
            "function":"load",
            "class":"lsolesen\\pel\\PelExif",
            "type":"->"
         },
         {
            "file":"/apps/maps/vendor/lsolesen/pel/src/PelJpeg.php",
            "line":126,
            "function":"load",
            "class":"lsolesen\\pel\\PelJpeg",
            "type":"->"
         },
         {
            "file":"/apps/maps/lib/Service/PhotofilesService.php",
            "line":442,
            "function":"__construct",
            "class":"lsolesen\\pel\\PelJpeg",
            "type":"->"
         },
         {
            "file":"/apps/maps/lib/Service/PhotofilesService.php",
            "line":384,
            "function":"getExifPelBackup",
            "class":"OCA\\Maps\\Service\\PhotofilesService",
            "type":"->"
         },
         {
            "file":"/apps/maps/lib/Service/PhotofilesService.php",
            "line":264,
            "function":"getExif",
            "class":"OCA\\Maps\\Service\\PhotofilesService",
            "type":"->"
         },
         {
            "file":"/apps/maps/lib/BackgroundJob/AddPhotoJob.php",
            "line":56,
            "function":"addPhotoNow",
            "class":"OCA\\Maps\\Service\\PhotofilesService",
            "type":"->"
         },
         {
            "file":"/lib/public/BackgroundJob/Job.php",
            "line":79,
            "function":"run",
            "class":"OCA\\Maps\\BackgroundJob\\AddPhotoJob",
            "type":"->"
         },
         {
            "file":"/lib/public/BackgroundJob/QueuedJob.php",
            "line":47,
            "function":"execute",
            "class":"OCP\\BackgroundJob\\Job",
            "type":"->"
         },
         {
            "file":"/cron.php",
            "line":128,
            "function":"execute",
            "class":"OCP\\BackgroundJob\\QueuedJob",
            "type":"->"
         }
      ],
      "File":"/apps/maps/vendor/lsolesen/pel/src/PelIfd.php",
      "Line":447,
      "CustomMessage":"--"
   },
   "id":"61d4adc080563"
}

[spalinger]

Uninstalling the App Maps and installing it again helped, I don't see a blocked cron job or the error anymore for the last 24 hours since doing that.
NC 23.0.0, not on Docker.

[GHJester]

@spalinger yes, I don't see the error message anymore. I don't know why. But what I'm facing now is that a lot of pictures are not displayed anymore. I only see around 1k pictures out of more than 10K on the map

[umgfoin]

This is a problem in dependency PEL:
Currently version 0.9.7 is pulled in. PEL-version 0.9.10 fixes some but not all of the problems.
@mondrake's PR seems to work well with NC23 & PHP8.0, but it hasn't been merged, yet.