Proposal for favorite sharing by public link

.babelrc.js

@@ -0,0 +1,11 @@
+module.exports = {
+    plugins: [
+        '@babel/plugin-syntax-dynamic-import',
+        '@babel/plugin-proposal-object-rest-spread'
+    ],
+    presets: [
+        [
+            '@babel/preset-env'
+        ]
+    ]
+}

.editorconfig

@@ -0,0 +1,9 @@
+root = true
+
+[*]
+charset = utf-8
+indent_style = space
+indent_size = 4
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true

.eslintignore

@@ -0,0 +1,12 @@
+js/
+l10n/
+src/adminSettings.js
+src/contactsController.js
+src/devicesController.js
+src/favoritesController.js
+src/filetypes.js
+src/nonLocalizedPhotosController.js
+src/photosController.js
+src/script.js
+src/tracksController.js
+src/utils.js

.eslintrc.js

@@ -0,0 +1,26 @@
+module.exports = {
+  root: true,
+  env: {
+    node: true
+  },
+  extends: [
+    "nextcloud"
+  ],
+  rules: {
+    "vue/component-name-in-template-casing": ["error", "PascalCase"],
+    "no-console": process.env.NODE_ENV === "production" ? "error" : "off",
+    "no-debugger": process.env.NODE_ENV === "production" ? "error" : "off"
+  },
+  globals: {
+    OC: false,
+    OCA: false,
+    t: false,
+    n: false,
+    $: false // TODO: remove once jQuery has been removed
+  },
+  parserOptions: {
+    ecmaVersion: 6,
+    sourceType: "module",
+    parser: "babel-eslint"
+  }
+};

.gitignore

@@ -16,6 +16,9 @@ yarn-debug.log*
 yarn-error.log*
 package-json.log*
 
+# Ide
+.idea/
+
 # Runtime data
 pids
 *.pid

.stylelintignore

@@ -0,0 +1 @@
+css/

.stylelintrc.json

@@ -0,0 +1,18 @@
+{
+    "extends": ["stylelint-config-recommended-scss"],
+    "rules": {
+        "media-feature-name-no-unknown": true,
+        "property-no-unknown": true,
+        "selector-pseudo-class-no-unknown": true,
+        "selector-pseudo-element-no-unknown": [true, {
+            "ignorePseudoElements": ["v-deep"]
+        }],
+        "selector-type-no-unknown": true,
+        "string-no-newline": true,
+        "unit-case": "lower",
+        "unit-no-unknown": true,
+        "indentation": [4, {
+            "severity": "error"
+        }]
+    }
+}

appinfo/application.php

@@ -12,14 +12,14 @@
 namespace OCA\Maps\AppInfo;
 
 
-use OC\AppFramework\Utility\SimpleContainer;
-use OCA\Maps\Service\AddressService;
+use OCA\Maps\DB\FavoriteShareMapper;
+use OCA\Maps\Controller\PublicFavoritesApiController;
 use \OCP\AppFramework\App;
-use OCA\Maps\Controller\PageController;
 use OCA\Maps\Controller\UtilsController;
 use OCA\Maps\Controller\FavoritesController;
 use OCA\Maps\Controller\FavoritesApiController;
 use OCA\Maps\Controller\DevicesController;
+use OCA\Maps\Controller\PublicPageController;
 use OCA\Maps\Controller\DevicesApiController;
 use OCA\Maps\Controller\RoutingController;
 use OCA\Maps\Controller\TracksController;
@@ -66,9 +66,14 @@ public function __construct (array $urlParams=array()) {
                     $c->query('ServerContainer')->getLogger(),
                     new FavoritesService(
                         $c->query('ServerContainer')->getLogger(),
-                        $c->query('ServerContainer')->getL10N($c->query('AppName'))
+                        $c->query('ServerContainer')->getL10N($c->query('AppName')),
+                        $c->query('ServerContainer')->getSecureRandom()
                     ),
-                    $c->query('ServerContainer')->getDateTimeZone()
+                    $c->query('ServerContainer')->getDateTimeZone(),
+                  new FavoriteShareMapper(
+                    $c->query('DatabaseConnection'),
+                    $c->query('ServerContainer')->getSecureRandom()
+                  )
                 );
             }
         );
@@ -89,7 +94,43 @@ public function __construct (array $urlParams=array()) {
                     $c->query('ServerContainer')->getLogger(),
                     new FavoritesService(
                         $c->query('ServerContainer')->getLogger(),
-                        $c->query('ServerContainer')->getL10N($c->query('AppName'))
+                        $c->query('ServerContainer')->getL10N($c->query('AppName')),
+                        $c->query('ServerContainer')->getSecureRandom()
+                    )
+                );
+            }
+        );
+
+        $container->registerService(
+            'PublicFavoritesAPIController', function ($c) {
+                return new PublicFavoritesApiController(
+                    $c->query('AppName'),
+                    $c->query('Request'),
+                    $c->query('Session'),
+                    new FavoritesService(
+                        $c->query('ServerContainer')->getLogger(),
+                        $c->query('ServerContainer')->getL10N($c->query('AppName')),
+                        $c->query('ServerContainer')->getSecureRandom()
+                    ),
+                  new FavoriteShareMapper(
+                    $c->query('DatabaseConnection'),
+                    $c->query('ServerContainer')->getSecureRandom()
+                  )
+                );
+            }
+        );
+
+        $container->registerService(
+            'PublicPageController', function ($c) {
+                return new PublicPageController(
+                    $c->query('AppName'),
+                    $c->query('Request'),
+                    $c->query('Session'),
+                    $c->query('ServerContainer')->getConfig(),
+                    $c->query('Logger'),
+                    new FavoriteShareMapper(
+                        $c->query('DatabaseConnection'),
+                        $c->query('ServerContainer')->getSecureRandom()
                     )
                 );
             }

appinfo/routes.php

@@ -12,6 +12,7 @@
         ['name' => 'page#index', 'url' => '/', 'verb' => 'GET'],
         ['name' => 'page#do_echo', 'url' => '/echo', 'verb' => 'POST'],
         ['name' => 'page#openGeoLink', 'url' => '/openGeoLink/{url}', 'verb' => 'GET'],
+        ['name' => 'public_page#sharedFavoritesCategory', 'url' => '/s/favorites/{token}', 'verb' => 'GET'],
 
 
         // utils
@@ -47,13 +48,30 @@
         ['name' => 'favorites_api#editFavorite', 'url' => '/api/{apiversion}/favorites/{id}', 'verb' => 'PUT'],
         ['name' => 'favorites_api#deleteFavorite', 'url' => '/api/{apiversion}/favorites/{id}', 'verb' => 'DELETE'],
 
+        // public favorites API
+        [
+            'name'         => 'favorites_api#preflighted_cors',
+            'url'          => '/api/1.0/public/favorites{path}',
+            'verb'         => 'OPTIONS',
+            'requirements' => ['path' => '.+']
+        ],
+        ['name' => 'public_favorites_api#getFavorites', 'url' => '/api/1.0/public/{token}/favorites', 'verb' => 'GET'],
+//        ['name' => 'public_favorites_api#addFavorite', 'url' => '/api/1.0/public/{token}/favorites', 'verb' => 'POST'],
+//        ['name' => 'public_favorites_api#editFavorite', 'url' => '/api/1.0/public/{token}/favorites/{id}', 'verb' => 'PUT'],
+//        ['name' => 'public_favorites_api#deleteFavorite', 'url' => '/api/1.0/public/{token}/favorites/{id}', 'verb' => 'DELETE'],
+
         // favorites
         ['name' => 'favorites#getFavorites', 'url' => '/favorites', 'verb' => 'GET'],
         ['name' => 'favorites#addFavorite', 'url' => '/favorites', 'verb' => 'POST'],
         ['name' => 'favorites#editFavorite', 'url' => '/favorites/{id}', 'verb' => 'PUT'],
         ['name' => 'favorites#deleteFavorite', 'url' => '/favorites/{id}', 'verb' => 'DELETE'],
         ['name' => 'favorites#deleteFavorites', 'url' => '/favorites', 'verb' => 'DELETE'],
+
+        // favorite categories
         ['name' => 'favorites#renameCategories', 'url' => '/favorites-category', 'verb' => 'PUT'],
+        ['name' => 'favorites#getSharedCategories', 'url' => '/favorites-category/shared', 'verb' => 'GET'],
+        ['name' => 'favorites#shareCategory', 'url' => '/favorites-category/{category}/share', 'verb' => 'POST'],
+        ['name' => 'favorites#unShareCategory', 'url' => '/favorites-category/{category}/un-share', 'verb' => 'POST'],
 
         ['name' => 'favorites#exportFavorites', 'url' => '/export/favorites', 'verb' => 'POST'],
         ['name' => 'favorites#importFavorites', 'url' => '/import/favorites', 'verb' => 'POST'],

composer.json

@@ -1,5 +1,8 @@
 {
     "require": {
         "lsolesen/pel": "^0.9.6"
+    },
+    "require-dev": {
+        "christophwurst/nextcloud_testing": "^0.9.1"
     }
 }

css/icons.scss

@@ -0,0 +1,39 @@
+/**
+ * @copyright Copyright (c) 2019, Paul Schwörer <hello@paulschwoerer.de>
+ *
+ * @author Paul Schwörer <hello@paulschwoerer.de>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+@mixin create-icon($varName, $icon, $dir, $color, $version: 1, $core: false) {
+  //noinspection CssInvalidFunction
+  #{$varName}: url(icon-color-path($icon, $dir, $color, $version, $core));
+}
+
+:root {
+  @include create-icon(
+      "--maps-icon-favorite-star",
+      "star-dark",
+      "actions",
+      #fff,
+      2,
+      true
+  );
+
+  // Feel free to add more icons here ...
+}

css/merged-public-favorite-share.scss

@@ -0,0 +1,23 @@
+/**
+ * @copyright Copyright (c) 2019, Paul Schwörer <hello@paulschwoerer.de>
+ *
+ * @author Paul Schwörer <hello@paulschwoerer.de>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+@import "icons";

css/style.scss

@@ -816,3 +816,33 @@ tr.selected td {
 .ui-autocomplete {
     z-index: 9999;
 }
+
+.favorite-share-link-clipboard-button {
+  display: none;
+  position: absolute;
+  right: 0;
+
+  &.visible {
+    display: block;
+  }
+
+  &.tooltip-visible .copied-tooltip {
+    opacity: .9;
+    transform: translate(-50%, 0);
+  }
+
+  .copied-tooltip {
+    position: absolute;
+    bottom: calc(100% - 10px);
+    line-height: normal;
+    left: 50%;
+    transition: transform .2s, opacity .2s;
+    transform: translate(-50%, 5px);
+    opacity: 0;
+    margin: auto;
+    background: #222;
+    color: #fff;
+    padding: 4px;
+    border-radius: 2px;
+  }
+}