fix Makefile sed on macOS #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on macOS 10.13.6 and Ubuntu 18.04 Signed-off-by: James Stout <stoutyhk@gmail.com>
tacruc
requested review from
julien-nc,
paulschwoerer and
v1r0x
and removed request for
v1r0x
Member
|
@jamesstout thanks a lot for your contribution! Can someone on macOS test? :) cc @georgehrke |
Member
|
Hmm, does this maybe break it on non-macOS? cc @tacruc @paulschwoerer @eneiluj |
Collaborator
|
The command still works on my ubuntu and should work on (all?) systems supporting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #242.
Tested on macOS 10.13.6 and Ubuntu 18.04
Signed-off-by: James Stout stoutyhk@gmail.com