-
-
Notifications
You must be signed in to change notification settings - Fork 102
Use Webpack #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Webpack #292
Conversation
b662d66 to
7fef5ba
Compare
0a6537a to
9abcee6
Compare
Yes! |
Are you trying to sell the PR? :P |
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good in general.
Neither did I test this nor have I a clue about the code of the app 🙊
|
How does this work together with #217? |
|
Huh, interesting. This is going to be a messy merge. #217 set up a lot of the same things as this PR with the main difference being that #217, the setup was just for the new feature and here, the idea is to simply migrate all of the JS for the app. Considering the name of #217, I didn't think to look in it for a change like this. |
|
Thats what I was afraid of. What would be the besteht order of merging them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the @nextcloud/router dependency in package.json. Shouldn't it be a production dependency?
Apart from that LGTM
|
@gary-kim Solid work!
It should actually be quite straightforward to merge this with the changes I did. I'd suggest to merge this commit first and I'll take care about merging the changes into #217 before merging #217 into master.
I was also interested in migrating the app to Vue, I'd be glad to lend a hand in doing so. In my PR you might find some useful components, that can be expanded on. |
Signed-off-by: Gary Kim <gary@garykim.dev>
9abcee6 to
7aafdd6
Compare
You too @paulschwoerer!
Thank you! I'll be sure to make good use of those. |
|
Is it ready to merge? |
🚀 Ready to merge! EDIT: Actually, let me add the |
Signed-off-by: Gary Kim <gary@garykim.dev>
Closes #252
Being a bit conservative with the milestone for now. 😄
There's quite a lot more that could be done for cleanup but I think it'd be better to put that in a follow-up PR.
EDIT: Someone who has access to settings for the repo: could you enable the
projectsfeature? I'd like to make a project for migration to Vue.EDIT 3: Once this is done, PR incoming for migrating admin settings to Vue.
EDIT 4:
@eneiluj @jancborchardt
package-lock.jsonandcomposer.lockbeing in the.gitignorefile caused me some confusion. I just read #44.I just removed those lines from
.gitignoreand committed those files in this PR.Just for future reference,
package-lock.jsonandcomposer.lockshould be committed into source control: package-lock.json documentation && composer.lock documentation 😄. (I don't mean that with any negative intent)