Skip to content

Conversation

@julien-nc
Copy link
Member

Hey how, here's a bunch of new stuff.

Checking a few points remaining from @jancborchardt review in #44 and adding some improvements:

  • use more common photo preview size to increase chances it already has been generated
  • add context menus to photos, devices, tracks, contacts and favorites markers. Context menu allows same actions than sidebar context menus except destructive ones (which delete data).
  • fix photos, favorites, contacts, devices and tracks markers border design
  • set tooltips background color to main bg color, add a colored border
  • display tooltips on top of markers
  • now able to import kml/kmz favorite files comming from Maps.me or F-Droid Maps. "category" is preserved.
  • use OC.filePath instead of dirty css trick to display app images
  • search bar and routing inputs: autocomplete on contacts, devices, favorites and "My location". Press enter in the input (not an autocomplete entry) to perform OSM search and extend autocomplete data. There is a small behaviour difference between search and routing inputs because I don't want to make deep changes in leaflet-routing-machine.
  • select a search result => sets routing destination
  • multiple results with OSM search: extend autocomplete data
  • improve autocomplete match function
  • improve search place result popup
  • "add to favorites" button in search place result popup

This branch has been pre-merged with master to take care of small conflicts with tacruc-non-localized-pictures-devices-new branch. It's ready to merge.

Dear reviewers, do as you like, merge now or wait because I'll continue pushing to this branch.

My opinion is: It's operational so we could merge.

Off-topic: Have you seen the amount of translations done since we pushed rework-again in master? 🤘

@tacruc
Copy link
Collaborator

tacruc commented Apr 27, 2019

Is the DCO a Problem?

@julien-nc
Copy link
Member Author

I don't think so. Even if I didn't sign my commits, nobody else than me could have made this PR. I'll sign my future commits unless someone wants me to sign all commits in this PR.

Julien Veyssier added 27 commits April 27, 2019 18:33
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
…empty names

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
… hides geocoder autocompletion

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
…iple results

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Julien Veyssier added 5 commits April 27, 2019 18:33
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Member Author

Anyway it's now signed.

@tacruc tacruc merged commit 6695ce8 into master Apr 27, 2019
@jancborchardt jancborchardt added this to the 📜 1.0 - the basics milestone Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants