feat(dynamite)!: allow clients from the http package#1448
Merged
Conversation
provokateurin
requested changes
Jan 13, 2024
Member
Author
|
making this a draft as there is no timeline yet for the next http package release |
Leptopoda
force-pushed
the
refactor/dynamite/allow_http_clients
branch
from
f41398f to
2cb926e
Compare
provokateurin
requested changes
Jan 18, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
The dependency check for the http package is missing in dynamite
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
The useragent should be passed with the baseHeaders instead Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Leptopoda
force-pushed
the
refactor/dynamite/allow_http_clients
branch
from
2cb926e to
9d7d86a
Compare
provokateurin
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikolas Rimikis leptopoda@users.noreply.github.com
towards: #788
fixes: #1307
Sorry for the big PR but it couldn't be done in smaller ones.
The fixtures now only include the headers explicitly added and not the ones added by the cleint itself.
I haven't checked every edge case but regarding the NC code (without the reexported dynamite_runtime) the only breaking change should be that the
httpClientparameter now takes aClientinstead of anHttpClient.