This repository was archived by the owner on Oct 19, 2022. It is now read-only.
fix styles & fonts #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jancborchardt looks good to me 👍 |
Member
Author
|
@jospoortvliet do you want to deploy this? Not really a reason to wait for this til the release, right? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the font stack to use humanist (Open Sans, Frutiger) rather than realist (Helvetica) font style because Open Sans is also humanist. We use the same font stack in Nextcloud server.
Also switching to Open Sans Semibold instead of Bold. @jospoortvliet I already added it to the repo.
And lastly fixing the position of the background image to center. Follow-up to @vincchan’s #11
Please review @nextcloud/designers :)