Skip to content

Consider Merge into Desktop Client Repository #136

@i2h3

Description

@i2h3

This needs to be discussed with @camilasan, @mgallien, @nilsding, @Aiiaiiio and @Rello.

Pros

  • Coherent Git history. Functionally dependent code changes are no longer split across multiple repositories. The full scope of a bug fix or feature implementation becomes visible.
  • Less overhead. Less Git fiddling, less dependency reference management, less pull requests.
  • Simplified developer experience. The NextcloudIntegration.xcodeproj will always directly reference the Swift package from the same directory, no need to always manually and temporarily reference it in the Xcode project for testing code changes in the dependency.
  • Unlikely reuse. As the NextcloudIntegration.xcodeproj in the desktop client repository shows, this actually is not a fully standalone solution to implement a file provider extension for a Nextcloud. It could be, but some code has to be moved in either direction for that first. The likelihood of others adopting this package in their own projects is expected to be very low.

Cons

  • The macOS file provider extension is a very specific module of the overall product. Kicking off all the desktop client checks on every change specific to this appears to be overkill and ineffective.

Other

  • This being a standalone project likely is the result of starting as a personal project of @claucambra and to not impact the desktop client project too much. By now, it has become an essential feature.
  • It could be carved out of the desktop repository again, the key is to keep the Swift package itself well isolated.

Tasks

  • All work in progress branches must be integrated or discarded first. Especially the Swift 6 compatibility effort (Swift 6 Support #96 and related branch).
  • GitHub Actions must be migrated, too. At best, with restrictions based on paths of changes.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions