Skip to content

Conversation

@korelstar
Copy link
Member

Nextcloud 14 will introduce a complete new search, see nextcloud/server#9912. This PR implements the new search API if notes is running on Nextcloud >= 14. If notes is running on Nextcloud < 14, the old style search is used. This means, that this PR is fully backward-compatible. However, we can remove the old-style search when Nextcloud 13 isn't supported anymore.

Fixes #43.

@korelstar korelstar added the enhancement New feature or request label Jul 22, 2018
@korelstar
Copy link
Member Author

I've also added two small, related things:

  • show loading icon in navigation while loading the list of notes (instead of "No notes found")
  • show "No search result for {{search}}" when using search (instead of "No notes found")

@korelstar korelstar merged commit 71dd9e5 into master Jul 29, 2018
@korelstar korelstar deleted the search branch July 29, 2018 20:59
@korelstar korelstar modified the milestone: 2.4.0 Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants