Update code to php 7.0 #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
feature/noid/update-to-php-7.0
branch
from
86dede7 to
123e0d3
Compare
nickvergessen
force-pushed
the
feature/noid/update-to-php-7.0
branch
from
123e0d3 to
5ecd084
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feature/noid/update-to-php-7.0
branch
from
5ecd084 to
7373f8d
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feature/noid/update-to-php-7.0
branch
from
7e4826e to
4822fc0
Compare
MorrisJobke
reviewed
Feb 20, 2018
| <licence>agpl</licence> | ||
| <author>Joas Schilling</author> | ||
|
|
||
| <default_enable/> |
Member
There was a problem hiding this comment.
This is not really needed. We use the shipped.json from the server repo
Member
Author
There was a problem hiding this comment.
default enabled is not equal to "shipped" and not equal to "always enabled". there is no information in shipped.json for "default enabled".
And yes, the value is read from info.xml
https://github.com/nextcloud/server/blob/9dc3b0480228a3c35b3b7a7cb1a904006f7e0762/lib/private/Installer.php#L521
Member
There was a problem hiding this comment.
Ah .. .yes mixed it up. Sorry.
Member
Author
|
Tests pass, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.