Skip to content

Align the notification subject vertically to the icon #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jul 17, 2019
Merged

Align the notification subject vertically to the icon #381

nickvergessen merged 1 commit into from
Jul 17, 2019

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 16, 2019

Before:
image

After:
image

@juliusknorr
Align the notification subject vertically to the icon
e93a106 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added this to the Nextcloud 17 milestone Jul 16, 2019
@nickvergessen
Copy link
Member

nickvergessen commented Jul 16, 2019

Does it also work with multiline headers?

@MorrisJobke MorrisJobke mentioned this pull request Jul 16, 2019
Merged
28 tasks
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 17, 2019

Yes, multiple lines will just be top aligned as before:

image

@nickvergessen nickvergessen merged commit f1fb322 into master Jul 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the design/align-subject branch July 17, 2019 08:19
@nickvergessen nickvergessen mentioned this pull request Jul 17, 2019
Closed
@nickvergessen
Copy link
Member

nickvergessen commented Jul 17, 2019

/backport to stable16

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 17, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 17, 2019

backport to stable16 in #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

Assignees

No one assigned

Labels

3. to review bug design

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @nickvergessen @jancborchardt