Skip to content

Don't shutdown the notifications when it freezes by browser shutdown #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jun 22, 2020
Merged

Don't shutdown the notifications when it freezes by browser shutdown #657

nickvergessen merged 1 commit into from
Jun 22, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 9, 2020

Another attempt to try to recover notifications when the browser reopens after a night of suspend.

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jun 9, 2020
@rullzer
Copy link
Member

rullzer commented Jun 10, 2020

sure...

@ChristophWurst I guess we should have the notifications also isten to the online/offline event?

@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 10, 2020

It is already listening, but in case of 404 we stopped it.
I would have assumed we dont get a 404 in case the browser suspends. So this is another attempt towards this.

@rullzer
Copy link
Member

rullzer commented Jun 10, 2020

It is already listening, but in case of 404 we stopped it.
I would have assumed we dont get a 404 in case the browser suspends. So this is another attempt towards this.

AH fair enough

rullzer
rullzer reviewed Jun 10, 2020
View reviewed changes
@nickvergessen nickvergessen force-pushed the bugfix/noid/dont-shutdown-notifications branch from ef4aa06 to 98fb803 Compare June 10, 2020 09:00
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 22, 2020

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the bugfix/noid/dont-shutdown-notifications branch from 98fb803 to 00f0a99 Compare June 22, 2020 10:56
@nickvergessen
Don't shutdown the notifications when it freezes by browser shutdown
4334b1e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/dont-shutdown-notifications branch from 00f0a99 to 4334b1e Compare June 22, 2020 12:47
@nickvergessen nickvergessen merged commit b6a4db6 into master Jun 22, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/dont-shutdown-notifications branch June 22, 2020 12:49
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 22, 2020

/backport to stable19

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer left review comments

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

4. to release bug feature: frontend 🖌️

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @rullzer