Skip to content

Don't push without internet connection #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jul 9, 2020
Merged

Don't push without internet connection #689

nickvergessen merged 1 commit into from
Jul 9, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 9, 2020

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jul 9, 2020
@nickvergessen nickvergessen requested a review from rullzer July 9, 2020 13:32
rullzer
rullzer approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nickvergessen
Don't push without internet connection
4d2766c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/dont-push-without-internet-connection branch from dba2767 to 4d2766c Compare July 9, 2020 15:08
@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 9, 2020

Of course there are tests that need adapting

@nickvergessen nickvergessen merged commit 3880511 into master Jul 9, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/dont-push-without-internet-connection branch July 9, 2020 15:46
@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 13, 2020

/backport to stable19

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 13, 2020

/backport to stable18

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 13, 2020

/backport to stable17

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 13, 2020
Merged
This was referenced Jul 13, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

Assignees

No one assigned

Labels

3. to review bug feature: push 📲

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @rullzer