Skip to content

Fix "exports is not defined" error #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Mar 26, 2021
Merged

Fix "exports is not defined" error #902

skjnldsv merged 2 commits into from
Mar 26, 2021

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Mar 26, 2021

Adjust webpack config to accomodate for the updates of @babel/preset-env from #899

Fixes nextcloud/server#26314

Inspired by a similar issue we had on the talk repo: nextcloud/spreed@5673db9#diff-3e31f6f375484b2dfd4629faed9e5183ac6568ebdbc67ec752e10c41a35250c6R72

@PVince81 PVince81 added this to the Nextcloud 22 milestone Mar 26, 2021
@PVince81 PVince81 requested a review from nickvergessen March 26, 2021 10:17
@PVince81 PVince81 self-assigned this Mar 26, 2021
@PVince81 PVince81 added the bug label Mar 26, 2021
This was referenced Mar 26, 2021
Closed
Merged
@PVince81
Copy link
Member Author

PVince81 commented Mar 26, 2021

/compile amend /

@PVince81 @npmbuildbot-nextcloud
Fix "exports is not defined" error
7552bbc 
Adjust webpack config to accomodate for the updates or @babel/preset-env

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the bugfix/noid/fix-babel-loading-exports-not-defined branch from 5149738 to 7552bbc Compare March 26, 2021 10:21
@nickvergessen nickvergessen requested a review from skjnldsv March 26, 2021 10:22
MorrisJobke
MorrisJobke approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen
Copy link
Member

nickvergessen commented Mar 26, 2021

Seems to work and we do the same in talk, but I'd still like confirmation by another JS expert

skjnldsv
skjnldsv reviewed Mar 26, 2021
View reviewed changes
@PVince81
Copy link
Member Author

PVince81 commented Mar 26, 2021

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the bugfix/noid/fix-babel-loading-exports-not-defined branch from 01426a5 to b86c718 Compare March 26, 2021 11:17
@PVince81
Copy link
Member Author

PVince81 commented Mar 26, 2021

CI is green. I've also retested this PR's state after checking it out again and it works.

@skjnldsv are you ok with the babelrc changes ?

@nickvergessen
Copy link
Member

nickvergessen commented Mar 26, 2021

Merge with babel.config.js please

nickvergessen
nickvergessen reviewed Mar 26, 2021
View reviewed changes
@PVince81 PVince81 force-pushed the bugfix/noid/fix-babel-loading-exports-not-defined branch from b86c718 to 5c183ac Compare March 26, 2021 11:46
nickvergessen
nickvergessen requested changes Mar 26, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@PVince81
Copy link
Member Author

PVince81 commented Mar 26, 2021

done. merged the configs, tested then squashed

@PVince81
Copy link
Member Author

PVince81 commented Mar 26, 2021

I did run make dev-setup && make build-js-production every time, and yet it doesn't accept my compiled assets.

@PVince81
Copy link
Member Author

PVince81 commented Mar 26, 2021

/compile amend /

@PVince81 @npmbuildbot-nextcloud
Move babel/env config into babelrc file
ac70fa9 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the bugfix/noid/fix-babel-loading-exports-not-defined branch from 5c183ac to ac70fa9 Compare March 26, 2021 11:49
@skjnldsv
Copy link
Member

skjnldsv commented Mar 26, 2021

I wonder if we could have a global babel config too.
Would be nice

@PVince81
Copy link
Member Author

PVince81 commented Mar 26, 2021

I wonder if we could have a global babel config too.
Would be nice

I wonder too, but won't be delivered today.
There's a master branch that is waiting to be unblocked: nextcloud/server#26314

@skjnldsv skjnldsv merged commit 330f50a into master Mar 26, 2021
@skjnldsv skjnldsv deleted the bugfix/noid/fix-babel-loading-exports-not-defined branch March 26, 2021 11:59
@skjnldsv
Copy link
Member

skjnldsv commented Mar 26, 2021

I wonder too, but won't be delivered today.

Let me test

@skjnldsv skjnldsv mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@PVince81 PVince81

Labels

3. to review bug

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

[master] Consistent sharing acceptance test failure

5 participants

@PVince81 @nickvergessen @skjnldsv @MorrisJobke