fix: url encode file name #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
approved these changes
May 20, 2025
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Maybe with an comment, otherwise there is not contextual information, neither in the commit message.
with a special character in the file name (namely, an apostrophe) the office online server will throw a parsing/validation error when trying to load a spreadsheet Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
elzody
force-pushed
the
fix/apostrophe-file-name
branch
from
1642d59 to
7d5846c
Compare
juliusknorr
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue that spreadsheets will not open if there is an apostrophe or other unexpected symbol in the file's name. It simply should be URL encoded so that when it is passed to the
documents.phptemplate, it can be requested properly.Checklist