Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 12, 2025

In Nextcloud en always refers to en_US so we should use that instead of
en_GB. This liekly also helps in cases where the office online server
has no British language pack installed

Signed-off-by: Julius Knorr jus@bitgrid.net

  • Resolves: #
  • Target version: main

Summary

TODO

  • Still need to figure out a better approach for the mapping then just the array order

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr juliusknorr added the 3. to review Waiting for reviews label Jun 12, 2025
In Nextcloud en always refers to en_US so we should use that instead of
en_GB. This liekly also helps in cases where the office online server
has no British language pack installed

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@enjeck enjeck force-pushed the fix/language-prefer-us branch from 706e542 to 2dd6ed4 Compare August 23, 2025 05:39
@enjeck
Copy link

enjeck commented Aug 24, 2025

We got confirmation that this works

@elzody
Copy link
Contributor

elzody commented Aug 28, 2025

Alright, maybe then we can follow up with what Julius said and get this in for now since it works.

@elzody elzody marked this pull request as ready for review August 28, 2025 23:34
@elzody elzody merged commit eac4702 into main Aug 28, 2025
38 checks passed
@elzody elzody deleted the fix/language-prefer-us branch August 28, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants