Consolidate fontend logic #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
javascript
artonge
force-pushed
the
artonge/feat/location_grouping_views
branch
from
a62b318 to
67f1a34
Compare
artonge
force-pushed
the
artonge/feat/location_grouping_views
branch
2 times, most recently
from
de84539 to
40cfa80
Compare
artonge
force-pushed
the
artonge/feat/location_grouping_views
branch
3 times, most recently
from
d25af00 to
1988d94
Compare
artonge
force-pushed
the
artonge/feat/location_grouping_views
branch
from
1988d94 to
ec6219b
Compare
skjnldsv
force-pushed
the
artonge/feat/location_grouping_views
branch
from
049950b to
eac254e
Compare
Base automatically changed from
artonge/feat/location_grouping_views
to
master
February 24, 2023 08:52
artonge
force-pushed
the
artonge/debt/consolidate_fontend
branch
2 times, most recently
from
a72bd4b to
9edd548
Compare
This was referenced May 3, 2023
artonge
force-pushed
the
artonge/debt/consolidate_fontend
branch
from
9edd548 to
82bfca4
Compare
artonge
force-pushed
the
artonge/debt/consolidate_fontend
branch
4 times, most recently
from
a33e136 to
d60fe7a
Compare
artonge
requested review from
a team,
Pytal,
marcelklehr and
szaimen
and removed request for
a team
nfebe
approved these changes
Jun 8, 2023
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Looks okay to me.
The earlier, we remove this compiled files from tracking I think the better!
artonge
force-pushed
the
artonge/debt/consolidate_fontend
branch
from
d60fe7a to
53180ea
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/debt/consolidate_fontend
branch
from
53180ea to
a10d2a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates the frontend store and fetcher logic for album, shared albums and public albums.
This uses the work done on the locations views #1334
Hopefully, this makes the code easier to maintain and contribute.
This could be extended to tag and faces, but I know Marcel did some other improvements/tweaks there, so keeping it to album for now.