Allow managing face clusters through DAV #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2022
Member
Edit: misunderstood, thought this was about assigning untagged faces to a tag, but this is about moving faces to a different tag. |
icewind1991
requested changes
Aug 18, 2022
Member
|
Overall approach looks good |
Member
Author
|
Thank you for reviewing! |
marcelklehr
commented
Aug 19, 2022
juliusknorr
reviewed
Aug 19, 2022
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
feat/faces-dav
branch
from
aa429d2 to
61e239a
Compare
… this user Signed-off-by: Marcel Klehr <mklehr@gmx.net>
juliusknorr
reviewed
Aug 24, 2022
juliusknorr
approved these changes
Aug 24, 2022
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Small optimisation comment, but otherwise looks good
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL schema is:
Face clusters can be renamed using MOVE, files can be assigned to a different cluster using MOVE, both can be removed using DELETE.
Based on nextcloud/photos#1146