Skip to content

Feature/noid/more profile fields #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 18 commits into from
Apr 1, 2021
Merged

Feature/noid/more profile fields #280

nickvergessen merged 18 commits into from
Apr 1, 2021

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 31, 2021 •
edited by Nienzu
Loading

@nickvergessen
Hide login name policy when email is used
58712c8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add phone and display name field
d140ee8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Don't break with older versions
2b8dc3c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Remove deprecated action
0703c5a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Mar 31, 2021
@nickvergessen nickvergessen marked this pull request as ready for review March 31, 2021 15:50
@nickvergessen
Move admin settings to Vue
4301242 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix PHP CS
d34e6c2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add new admin settings to show/enforce fullname/phone
8ef7b52 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix only showing first letter of "invalid verification error"
6694e08 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Compile javascript
1246f0a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Only allow phone when we can save it
2d08501 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix unit tests
2747ad7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix compatibility with Nextcloud 20
4430d2b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Don't mention verification link when the login flow is used
afcee9b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 1, 2021

/compile /

@npmbuildbot-nextcloud
Compile assets
38fe83b 
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
rullzer
rullzer reviewed Apr 1, 2021
View reviewed changes
rullzer
rullzer approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

skjnldsv
skjnldsv reviewed Apr 1, 2021
View reviewed changes
skjnldsv
skjnldsv reviewed Apr 1, 2021
View reviewed changes
skjnldsv
skjnldsv reviewed Apr 1, 2021
View reviewed changes
skjnldsv
skjnldsv reviewed Apr 1, 2021
View reviewed changes
skjnldsv
skjnldsv reviewed Apr 1, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

@nickvergessen
Simplify the setup structure
467029b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Use SettingsSection
29023f2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 1, 2021

/compile /

npmbuildbot-nextcloud bot and others added 2 commits April 1, 2021 11:38
@npmbuildbot-nextcloud
Compile assets
548da50 
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@nickvergessen
Don't package webpack.js
6c43891 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen requested a review from skjnldsv April 1, 2021 11:39
@nickvergessen nickvergessen mentioned this pull request Apr 1, 2021
Closed
@nickvergessen nickvergessen merged commit ddab69b into master Apr 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/noid/more-profile-fields branch April 1, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@Nienzu Nienzu Awaiting requested review from Nienzu

Assignees

@nickvergessen nickvergessen

Labels

3. to review enhancement feature: frontend 🖌️ feature: settings ⚙️

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @rullzer @skjnldsv @marcoambrosini