-
Notifications
You must be signed in to change notification settings - Fork 18
debian package #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
debian package #14
Conversation
|
There are a few issues. This layout isn't typical of debian packages, but it's further along than where I got. Perhaps I can take a look at some improvements. I'll comment inline. |
|
Ah, I can't comment inline. Can you give me that ability? Thanks! |
|
Sorry but I don't have the rights to do it. Maybe @jospoortvliet ? In the meanwhile I suggest you to write your findings here. |
| @@ -0,0 +1,8 @@ | |||
| Alias /nextcloud /usr/share/nextcloud/ | |||
| <Directory "/usr/share/nextcloud/"> | |||
| Options MultiViews FollowSymlinks | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MultiViews shouldn't be necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, how can i test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ownCloud 8.1, it was explicitly forbidden. I can't imagine that they started depending on it in the meantime.
debian/testbed/nextcloud/Dockerfile
Outdated
| FROM debian | ||
| RUN apt-get update | ||
| #just to speedup after changing the deb | ||
| RUN apt-get install -y php7.0-xml php7.0 php7.0-cgi php7.0-cli php7.0-gd php7.0-curl php7.0-zip php7.0-mysql php7.0-mbstring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Join these lines, see guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wil delete the line.
debian/.bash_history
Outdated
| apt-get install apache4 | ||
| apt-get install apache3 | ||
| exit | ||
| exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file.
debian/DEBIAN/control
Outdated
| Section: misc | ||
| Priority: optional | ||
| Architecture: amd64 | ||
| Depends: php7.0,php7.0-xml,php7.0-cgi,php-cli,php7.0-mysql,php7.0-mbstring,php7.0-gd,php7.0-curl,php7.0-zip,apache2,libapache2-mod-php7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't depend on apache2 imho and just optionally provide integration. It should provide integration with nginx as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i split the package into at least 3 peaces
- nexcloud
- nextcloud-apache
- nextcloud-nginx
this way other Webserver can be integrated as well
|
I'm not able to judge this PR. @luckyonesl @srbaker @adrianheine do you think I can merge it? |
|
@luckyonesl is it normal debian practice that files under /etc are writable by the software itself? I think owncloud, when installed from a deb package, had it's update mechanism disabled and its code kept read only |
|
No it is Not i have to fix this
Von meinem iPhone gesendet
… Am 05.04.2019 um 10:08 schrieb Alexander Bogdanov ***@***.***>:
@luckyonesl is it normal debian practice that files under /etc are writable by the software itself?
I think owncloud, when installed from a deb package, had it's update mechanism disabled and its code kept read only
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@luckyonesl hello again! Just to let you know, deb packaging is still an interesting topic, I am sure many people would like to see this PR improved and merged. Do you need any help? also note for future generations: original package sources seem to be available at https://github.com/owncloud/administration/tree/master/jenkins/obs_integration/templates |
this is the first rough implementation.
#5