Skip to content

Conversation

@luckyonesl
Copy link

@luckyonesl luckyonesl commented Dec 14, 2017

this is the first rough implementation.

#5

@gsanchietti
Copy link
Collaborator

I never created a Debian package, but I feel the bash_history file should be there.

Maybe @srbaker and @Fjodor42 can give some advice here.

@srbaker
Copy link

srbaker commented Dec 14, 2017

There are a few issues. This layout isn't typical of debian packages, but it's further along than where I got. Perhaps I can take a look at some improvements. I'll comment inline.

@srbaker
Copy link

srbaker commented Dec 14, 2017

Ah, I can't comment inline. Can you give me that ability? Thanks!

@gsanchietti
Copy link
Collaborator

Sorry but I don't have the rights to do it. Maybe @jospoortvliet ?

In the meanwhile I suggest you to write your findings here.

@@ -0,0 +1,8 @@
Alias /nextcloud /usr/share/nextcloud/
<Directory "/usr/share/nextcloud/">
Options MultiViews FollowSymlinks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MultiViews shouldn't be necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, how can i test it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ownCloud 8.1, it was explicitly forbidden. I can't imagine that they started depending on it in the meantime.

FROM debian
RUN apt-get update
#just to speedup after changing the deb
RUN apt-get install -y php7.0-xml php7.0 php7.0-cgi php7.0-cli php7.0-gd php7.0-curl php7.0-zip php7.0-mysql php7.0-mbstring

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Join these lines, see guide

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wil delete the line.

apt-get install apache4
apt-get install apache3
exit
exit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file.

Section: misc
Priority: optional
Architecture: amd64
Depends: php7.0,php7.0-xml,php7.0-cgi,php-cli,php7.0-mysql,php7.0-mbstring,php7.0-gd,php7.0-curl,php7.0-zip,apache2,libapache2-mod-php7.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't depend on apache2 imho and just optionally provide integration. It should provide integration with nginx as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i split the package into at least 3 peaces

  1. nexcloud
  2. nextcloud-apache
  3. nextcloud-nginx
    this way other Webserver can be integrated as well

@gsanchietti
Copy link
Collaborator

I'm not able to judge this PR.

@luckyonesl @srbaker @adrianheine do you think I can merge it?

@synchrone
Copy link

@luckyonesl is it normal debian practice that files under /etc are writable by the software itself?

I think owncloud, when installed from a deb package, had it's update mechanism disabled and its code kept read only

@luckyonesl
Copy link
Author

luckyonesl commented Apr 5, 2019 via email

@synchrone
Copy link

synchrone commented Jul 6, 2019

@luckyonesl hello again! Just to let you know, deb packaging is still an interesting topic, I am sure many people would like to see this PR improved and merged.

Do you need any help?

also note for future generations: original package sources seem to be available at https://github.com/owncloud/administration/tree/master/jenkins/obs_integration/templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants