users is not defined when sharing.maxAutocompleteResults is set

[blizzz]

Steps to reproduce

1. add 'sharing.maxAutocompleteResults' => 10, to your config.php
2. open the share dialog for a file
3. search for a potential sharee

Expected behaviour

No error

Actual behaviour

ReferenceError: users is not defined[Learn More] sharedialogview.js:410:1

Functionality is not compromised.

In the check in https://github.com/nextcloud/server/blob/master/core/js/sharedialogview.js#L406 the users variable (and following) are not set, after some restructuring.

This could be replaced by suggestions, but we cannot get just the length as we need to use it seperately per shareType.

Perhaps best to estimate the max value on _getSuggestions.

[nextcloud-bot]

GitMate.io thinks possibly related issues are #2568 (user can't change language in personal settings), #9698 (Search is not working in Shared Folders by Other users), #6707 (User cannot move shared file to shared folder), #4739 (Sharing with users disappear after link creation), and #9380 (autocompletion not working when sharing with zimbra drive user).