Rename 'enable'-checkbox for linksharing in filesapp-details

[newhinton]

Currently if you want to activate a link, you need to tick a checkbox. I think 'enable' is not quiet a good description for sharing a link.

Maybe 'share'/'unshare' would be a better description?

[newhinton]

@nextcloud/designers

[nextcloud-bot]

GitMate.io thinks possibly related issues are #2231 (Need to be renamed...), #9152 (Problem renaming folders), #9005 (c), #8628 (renaming shared folder - no actualization), and #10398 (Opening details after coming from favorites view is broken).

[enoch85]

This is not a Github issue, rather a translation issue.

Translations are done on Transifex, please join and find the string and translate it correctly.

Regarding the English wording, I'm not sure what it says now.

@MariusBluem Do you know?

[newhinton]

In english it's currently 'enable'. So, the translation in itself is not wrong, but i think to a user something different would be better, maybe 'share'/'unshare', depending on the state?

[newhinton]

Also a button instead of a checkbox could improve the share-ability. As of now, it may not be obvious for every user how to share a link with somebody outside of the nextcloud-instance

[MariusBluem]

@jancborchardt what do you think?

[juliusknorr]

Also a button instead of a checkbox could improve the share-ability. As of now, it may not be obvious for every user how to share a link with somebody outside of the nextcloud-instance

Why don't we get rid of the checkbox and just make the whole "Share link" entry clickable to enable link sharing. For disabling the link share we could simply add an entry to the popover menu.

Edit: we might need to adjust the wording a bit to make it clear what the state is:

Link share disabled:

Link share enabled:

[MorrisJobke]

AFAIK @jancborchardt or @skjnldsv already worked on a renaming, but I couldn't find the PR that changes this. There is a screenshot in #11537 (comment)

[jancborchardt]

We are working on it at #11537

The "Enable" part will be removed completely. We will move the checkbox towards the "Share link" part. And "Copy link" will be visible directly, outside of the menu. Also, when you check the "Share link", the link will be copied directly and feedback given in the form of a popover.

@newhinton if you want to check out #11537 and help you are very welcome! :) @skjnldsv and me are still focused on grid view at the moment.