"An unknown error has occurred" when not enough quota

[nickvergessen]

Happens on master:

1. Set the quota of a user to 0 or a few bytes
2. Upload a file as that user
3. Expected ❓

   server/apps/files/js/file-upload.js

   Lines 1027 to 1030 in a793b10

   	} else if (status === 507) {
   	// not enough space
   	OC.Notification.show(t('files', 'Not enough free space'), {type: 'error'});
   	self.cancelUploads();

   or

   server/apps/files/js/file-upload.js

   Lines 947 to 955 in a793b10

   	freeSpace = $('#free_space').val();
   	if (freeSpace >= 0 && selection.totalBytes > freeSpace) {
   	data.textStatus = 'notenoughspace';
   	data.errorThrown = t('files',
   	'Not enough free space, you are uploading {size1} but only {size2} is left', {
   	'size1': humanFileSize(selection.totalBytes),
   	'size2': humanFileSize($('#free_space').val())
   	});
   	}

4. Actually throws 💥

   server/apps/files/js/file-upload.js

   Lines 1032 to 1040 in a793b10

   	// HTTP connection problem or other error
   	var message = t('files', 'An unknown error has occurred');
   	if (upload) {
   	var response = upload.getResponse();
   	if (response) {
   	message = response.message;
   	}
   	}
   	OC.Notification.show(message || data.errorThrown, {type: 'error'});

Works fine in stable14

@skjnldsv can you have a look? You modified the upload stuff in general lately?

[nextcloud-bot]

GitMate.io thinks possibly related issues are #2017 (quota), #9960 (Error occurred during the update process), #8618 (error occurs when try to enable "External Storage Support"), #8050 (Quota issues ), and #3958 (An error occured: Bad signature - corrupted encrypted files).

[skjnldsv]

Ah yes, introduced by a793b10

[ChristophWurst]

@skjnldsv ping? A fix would be awesome ❤️