2FA settings icons don’t invert in dark theme

[jancborchardt]

With the dark theme, 2FA settings look like this:

That’s because they are loaded in the <img> tag. Ideally it should be changed to use a class on the header like icon-… so it’s used as background-image.

Documentation on that at: https://docs.nextcloud.com/server/latest/developer_manual/design/css.html#scss-icons-mixins

[nickvergessen]

Code in question

server/settings/templates/settings/personal/security.php

Lines 76 to 82 in 1f47c69

	/** @var \OCP\Authentication\TwoFactorAuth\IProvidesPersonalSettings $provider */
	$provider = $data['provider'];
	if ($provider instanceof \OCP\Authentication\TwoFactorAuth\IProvidesIcons) {
	$icon = $provider->getDarkIcon();
	} else {
	$icon = image_path('core', 'actions/password.svg');
	}