[Accessibility] "Show password" checkbox doesn't provide label or accessible name

[javido]

Steps to reproduce

1. Open admin account creation form
2. With screen reader (NVDA or Orca) press tab key until give focus to the checkbox

Expected behaviour

Tell us what should happen
Screen reader should announce "Show password" unchecked chebox

Actual behaviour

Tell us what happens instead
Screen reader only announces that there is a checkbox, but users don't know this is for showing the password.

Server configuration

Operating system:
Ubuntu 19.04, Mozilla Firefox and Orca screen reader.
Web server:
Apache 2
Database:
MariaDB
PHP version:
PHP 7.2
Nextcloud version: (see Nextcloud admin page)
Nextcloud Master
Updated from an older Nextcloud/ownCloud or fresh install:
Fresh installation
Where did you install Nextcloud from:
Git repository

[kesselb]

You are referring to the setup page right?

server/core/templates/installation.php

Lines 47 to 53 in 7fea531

	<input type="password" name="adminpass" data-typetoggle="#show" id="adminpass"
	placeholder="<?php p($l->t( 'Password' )); ?>"
	value="<?php p($_['adminpass']); ?>"
	autocomplete="off" autocapitalize="none" autocorrect="off" required>
	<label for="adminpass" class="infield"><?php p($l->t( 'Password' )); ?></label>
	<input type="checkbox" id="show" class="hidden-visually" name="show">
	<label for="show"></label>

How to fix this? @jancborchardt Like here #15881 with aria-label="Show password"?

[javido]

Yes, sure. Problems seems that label tag it's empty. label for show

[javido]

Label for show field should have "show password" text. If you don't want to make this text visible aria-label on input type checkbox it's ok.
BTW How I can insert html code in my comments? I am not familiarized with Github yet.

[kesselb]

BTW How I can insert html code in my comments? I am not familiarized with Github yet.

Like this https://help.github.com/en/articles/creating-and-highlighting-code-blocks

[Sibin-Thomas]

Hey Can I fix this issue?

[kesselb]

Hey Can I fix this issue?

We appreciate your help 👍 Please note that there is already a pull request #16642 with a proposed solution. I'm not sure what the status is.