Configuration profile for macOS/iOS contains internal server ip and does not respect overwritehost

[Nils160988]

Steps to reproduce

1. Install Nextcloud 18
2. Go to Settings / Mobile & Desktop
3. Review the configuration profile for mac/iOS

Expected behaviour

CalDAVHostname is taken from the value provided in overwritehost in config.php

Actual behaviour

CalDAVHostname is set to internal IP-address.

Server configuration

Operating system: Ubuntu 18.04

Web server: Apache 2.4.29

Database: Mariadb 10.1.44

PHP version: 7.2.24

Nextcloud version: (see Nextcloud admin page) 18.0.1

Updated from an older Nextcloud/ownCloud or fresh install: updated

Where did you install Nextcloud from: nextcloud.com

Nextcloud configuration:

Config report

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "xx.xx.xxx.xx"
        ],
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "forwarded_for_headers": [
            "HTTP_X_FORWARDED_FOR"
        ],
        "overwritehost": "sub.domain.de",
        "overwriteprotocol": "https",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "18.0.1.3",
        "overwrite.cli.url": "https:\/\/sub.domain.de\/nextcloud",
        "htaccess.RewriteBase": "\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "mysql.utf8mb4": true,
        "maintenance": false,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "mail_smtpmode": "sendmail",
        "mail_sendmailmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "force_language": "de",
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "loglevel": 2,
        "updater.release.channel": "stable"
    }
}

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: LDAP

Client configuration

Browser: Firefox 73.0

Operating system: Ubuntu 18.04

[kesselb]

Thanks for reporting 👍

server/apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php

Line 128 in 5bf3d1b

$absoluteURL = $request->getAbsoluteUrl();

That needs to be done different because $request is a instance of Sabre\HTTP\RequestInterface and not OCP\IRequest.

Index: apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php	(revision c44511b09924d5eddae2a1ef35d92ce12ddec950)
+++ apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php	(date 1582728397157)
@@ -125,7 +125,7 @@
 			return false;
 		}
 
-		$absoluteURL = $request->getAbsoluteUrl();
+		$absoluteURL = $this->request->getServerHost();
 		$parsedUrl = parse_url($absoluteURL);
 		if (isset($parsedUrl['port'])) {
 			$serverPort = (int) $parsedUrl['port'];

Does that work for you?

[Nils160988]

No problem ;)
It does not work, Hostname is now empty.

[kesselb]

If your overwritehost is only sub.domain.de parse_url is not able to detect it properly.

<?php

var_dump(parse_url('sub.domain.de:8080'));
var_dump(parse_url('sub.domain.de'));

array(2) {
  ["host"]=>
  string(13) "sub.domain.de"
  ["port"]=>
  int(8080)
}
array(1) {
  ["path"]=>
  string(13) "sub.domain.de"
}

Solution A: Use the complete url with protocol.

Index: apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php	(revision c44511b09924d5eddae2a1ef35d92ce12ddec950)
+++ apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php	(date 1582735997384)
@@ -125,7 +125,7 @@
 			return false;
 		}
 
-		$absoluteURL = $request->getAbsoluteUrl();
+		$absoluteURL = $this->urlGenerator->getBaseUrl();
 		$parsedUrl = parse_url($absoluteURL);
 		if (isset($parsedUrl['port'])) {
 			$serverPort = (int) $parsedUrl['port'];

Solution B: Just prepend '//' to overwritehost will also work.

Index: apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php	(revision c44511b09924d5eddae2a1ef35d92ce12ddec950)
+++ apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php	(date 1582736079666)
@@ -125,7 +125,7 @@
 			return false;
 		}
 
-		$absoluteURL = $request->getAbsoluteUrl();
+		$absoluteURL = '//' . $this->request->getServerHost();
 		$parsedUrl = parse_url($absoluteURL);
 		if (isset($parsedUrl['port'])) {
 			$serverPort = (int) $parsedUrl['port'];

Mind to give it a try?

[Nils160988]

Perfect, both solutions work fine with the same result!

[kesselb]

cc @georgehrke

[georgehrke]

@Nils160988 @kesselb Looks Fine to me. Could either of you please send a pull request? Thx!

[Nils160988]

I could. Which solution do you prefer? For me, solution A looks a bit less "hacky"...

[georgehrke]

Yes, solution A looks good :)