Server upgrade not working without viewer

[juliusknorr]

• Install server from git for development purposes

• Have changes that bump the version or manually bump ìt in version.php

• Viewer is not installed but we get:

  The files of the app (viewer) were not replaced correctly. Make sure it is a version compatible with the server.

I think it should still be possible to run the server in dev setups without viewer being installed. cc @skjnldsv @rullzer

Caused by #18334 as always enabled apps are considered being installed no matter if they actually are

server/lib/private/App/AppManager.php

Line 137 in 3eee359

$alwaysEnabledApps = $this->getAlwaysEnabledApps();

[rullzer]

Yeah I know. But without viewer a lot of things do boom.
Maybe we just add a dev note to the readme to always install the viewer as well.

[skjnldsv]

Yeah, no idea what to do here.
It's pretty much the same with lots of apps for me.
Support, password policy, files_texteditor, firstrunwizard, notifications... Every update it's the same :p

[juliusknorr]

Those are different, because the server works fine if they are not installed at all (they are only marked as shipped), but viewer is the only one that is always enabled but not part of the repo.

Anyway I'm also fine with just properly documenting that. It just adds an additional step when getting started.

[skjnldsv]

Ah right! Server should work without viewer. We just emit some Viewer events, but they're checked before emit iirc, so we should do that sure :)

[tonyguepin]

This still is an issue in v18.0.6.
I guess that, when viewer is not taken out of the core/shipped.json alwaysEnabled list,
then the app should be part of the standard nextcloud layout.

[landryb]

occ upgrade always break when using a checkout from git, so one way or another (submodule? import viewer code?) it should be fixed..

[juliusknorr]

git clone https://github.com/nextcloud/viewer.git into your apps directory

[landryb]

well, sure now that im aware of this issue and understood the cryptic message that lead me there, but it isnt obvious for other users ;)

[PhrozenByte]

Ah right! Server should work without viewer. We just emit some Viewer events, but they're checked before emit iirc, so we should do that sure :)

Do I understand you right @skjnldsv that we can indeed remove viewer from alwaysEnabled in shipped.json?

By the way, I didn't experience any issues with the latest Git version until a upgrade was triggered by one of my dev apps. It looks like this is no huge issue... viewer is in shipped.json's alwaysEnabled since 17.0.5RC1 and was introduced by @rullzer (eb8ca37). @rullzer do you remember the reasons for this?

This still is an issue in v18.0.6.
I guess that, when viewer is not taken out of the core/shipped.json alwaysEnabled list,
then the app should be part of the standard nextcloud layout.

I agree. If Nextcloud server relies on viewer, its code should be moved to the server repo. Otherwise it breaks dev installations - and I just wasted about half an hour of valuable time just to fix this. As an alternative we could remove or refactor any code depending on viewer. That's probably the better solution. Where do we rely on viewer?

[skjnldsv]

Do I understand you right @skjnldsv that we can indeed remove viewer from alwaysEnabled in shipped.json?

No, Viewer needs to stay enabled.
It is required for other apps to work, because we currently don't support cross-apps dependencies
#18334