-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed
Labels
0. Needs triagePending check for reproducibility or if it fits our roadmapPending check for reproducibility or if it fits our roadmapbugfeature: language/translations (l10n/i18n)Localization and translation mattersLocalization and translation mattersfeature: search
Description
Fits:
Should be capitalised:
It is not a translation issue. The search providers only have to provide a getName() method for a translated string. The provides all return it in capitalized fashion ("Apps", …). In core/src/views/UnifiedSearch.vue:47 they are hard-lowercased.
The best distinction is done by the translators however.
My suggestion would be to add another method (as another interface to avoid breakage) that would return a string to be used within a sentence. And fall back to getName(). The hard lowercasing in the view would be removed.
The alternative would be to only remove the forced lower cased, which would end up in a strange picture at least in English:
@ChristophWurst @skjnldsv @jancborchardt what do you think?
Metadata
Metadata
Assignees
Labels
0. Needs triagePending check for reproducibility or if it fits our roadmapPending check for reproducibility or if it fits our roadmapbugfeature: language/translations (l10n/i18n)Localization and translation mattersLocalization and translation mattersfeature: search


