coloring of external storage folders not working

[jospoortvliet]

With Nextcloud 11RC1, I notice that the folders follow the color scheme, with one exception:

The external storage folder stays blue. I guess we should try to fix this, yes?

@nextcloud/designers ?

[juliusknorr]

I just had a quick look, this happens because the files_external app is overriding the icons from the mimetype javascript code.

server/apps/files_external/js/statusmanager.js

Lines 518 to 559 in 7e6f829

	changeFolderIcon: function (filename) {
	var file;
	var route;
	if (filename instanceof $) {
	//trElementList
	$.each(filename, function (index) {
	route = OCA.External.StatusManager.Utils.getIconRoute($(this));
	$(this).attr("data-icon", route);
	$(this).find('td:first-child div.thumbnail').css('background-image', "url(" + route + ")").css('display', 'none').css('display', 'inline');
	});
	} else {
	file = $("#fileList tr[data-file=\"" + this.jqSelEscape(filename) + "\"] > td:first-child div.thumbnail");
	var parentTr = file.parents('tr:first');
	route = OCA.External.StatusManager.Utils.getIconRoute(parentTr);
	parentTr.attr("data-icon", route);
	file.css('background-image', "url(" + route + ")").css('display', 'none').css('display', 'inline');
	}
	},
	/**
	* @param backend string with the name of the external storage backend
	* of the tr matching the folder name
	*/
	getIconRoute: function (tr) {
	var icon = OC.imagePath('core', 'filetypes/folder-external');
	var backend = null;
	if (tr instanceof $) {
	backend = tr.attr('data-external-backend');
	}
	switch (backend) {
	case 'windows_network_drive':
	icon = OC.imagePath('windows_network_drive', 'folder-windows');
	break;
	case 'sharepoint':
	icon = OC.imagePath('sharepoint', 'folder-sharepoint');
	break;
	}
	return icon;
	},

We could either add a check for OCA.Theming in the files_external or add the theming globally to the JS imagePath function like I did it with the PHP function in #840. I need to think a bit about what makes more sense.

@icewind1991 Is this extra code in files_external still needed? It looks like they were just for windows_network_drive and sharepoint apps which are not available for Nextcloud at the moment.