Allowed memory size of 536870912 bytes exhausted on activity stream

[nickvergessen]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Something in the recent version changed something which now causes memory issues on the activity stream.

Steps to reproduce

1. Go to the activity app
2. Wait ~16s until the stream shows
3. Check the nextcloud.log

{"reqId":"…","level":3,"time":"2022-03-11T07:35:58+00:00","remoteAddr":"…","user":"…","app":"PHP","method":"GET","url":"/ocs/v2.php/apps/activity/api/v2/activity/all?format=json&previews=true&since=55712887","message":"Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) at /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php#138","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:97.0) Gecko/20100101 Firefox/97.0","version":"23.0.3.0"}

Try it another time same error in a different place

{"reqId":"…","level":3,"time":"2022-03-10T22:20:24+00:00","remoteAddr":"…","user":"…","app":"PHP","method":"GET","url":"/ocs/v2.php/apps/activity/api/v2/activity/all?format=json&previews=true&since=0","message":"Allowed memory size of 536870912 bytes exhausted (tried to allocate 131072 bytes) at /var/www/html/lib/private/AppFramework/Middleware/CompressionMiddleware.php#89","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0","version":"23.0.3.0","id":"622a7aaeb8c9b"} 

Expected behavior

No error and the page shows quickly

Installation method

Manual installation

Operating system

Debian/Ubuntu

PHP engine version

PHP 7.4

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "github.client_id": "***REMOVED SENSITIVE VALUE***",
        "github.client_secret": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "updater.release.channel": "beta",
        "zammad.secret": "***REMOVED SENSITIVE VALUE***",
        "zammad.portal.secret": "***REMOVED SENSITIVE VALUE***",
        "zammad.download.secret": "***REMOVED SENSITIVE VALUE***",
        "log.condition": {
            "apps": [
                "perf_debug"
            ]
        },
        "trusted_domains": [
            "cloud.nextcloud.com"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "htaccess.RewriteBase": "\/",
        "overwrite.cli.url": "https:\/\/cloud.nextcloud.com\/",
        "version": "23.0.3.0",
        "dbtype": "mysql",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "mysql.utf8mb4": true,
        "logtimezone": "UTC",
        "log_rotate_size": 104857600,
        "loglevel": "2",
        "installed": true,
        "mail_smtpmode": "smtp",
        "ldapIgnoreNamingRules": false,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpsecure": "ssl",
        "mail_smtpauth": 1,
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpport": "465",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "appstore.experimental.enabled": true,
        "theme": "",
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
        "trashbin_retention_obligation": "auto, 30",
        "maintenance": false,
        "sentry.dsn": "***REMOVED SENSITIVE VALUE***",
        "sentry.public-dsn": "***REMOVED SENSITIVE VALUE***",
        "sentry.minimum.log.level": 3,
        "files_no_background_scan": true,
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [
            "General"
        ],
        "twofactor_enforced_excluded_groups": [],
        "debug": false,
        "minimum.supported.desktop.version": "3.4.1"
    }
}

List of activated Apps

N/A

Nextcloud Signing status

No response

Nextcloud Logs

{"reqId":"…","level":3,"time":"2022-03-10T22:20:24+00:00","remoteAddr":"…","user":"…","app":"PHP","method":"GET","url":"/ocs/v2.php/apps/activity/api/v2/activity/all?format=json&previews=true&since=0","message":"Allowed memory size of 536870912 bytes exhausted (tried to allocate 131072 bytes) at /var/www/html/lib/private/AppFramework/Middleware/CompressionMiddleware.php#89","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0","version":"23.0.3.0","id":"622a7aaeb8c9b"}

Additional info

Error started occuring after update from 23.0.2 to 23.0.3rc1

[nickvergessen]

Activities in the range:

        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_deleted",
        "app": "files",
        "type": "file_created",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_created",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_created",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_created",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",
        "app": "files",
        "type": "file_changed",

[PVince81]

sadly no full stack trace, so harder to pinpoint the exact code location

[nickvergessen]

I debugged the used memory:

\OC::$server->get(\Psr\Log\LoggerInterface::class)->error('Description#' . memory_get_usage(), ['app' => 'nickv']);

First file in the activity loop

9.772.896 ~9MB before this line
https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/Controller/APIv2Controller.php#L353
353.482.232 ~350MB after getInfoById

https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/Controller/APIv2Controller.php#L375
438.144.720 ~438MB after getFileInfo

The a second file without preview

440.345.368 ~440MB before this line
https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/Controller/APIv2Controller.php#L353
526.768.408 ~526MB after getInfoById and exiting here:
https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/Controller/APIv2Controller.php#L356

[nickvergessen]

Had forgotten this class is Activity internal.

So one level more to map it

File 1

• findInfoById#9774816
• https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/ViewInfoCache.php#L103
• chroot#9774904
• beforegetPath#9775280
• https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/ViewInfoCache.php#L114
• aftergetPath#353494584
• https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/ViewInfoCache.php#L117
• afteris_dir#353494744
• https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/ViewInfoCache.php#L143
• onreturn#353495448

File 2

• findInfoById#440434832
• https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/ViewInfoCache.php#L103
• chroot#440434808
• beforegetPath#440435184
• https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/ViewInfoCache.php#L114
• beforechrootTrashbin#526807496
• https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/ViewInfoCache.php#L122
• afterchrootTrashbin#526807496
• https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/ViewInfoCache.php#L125
• https://github.com/nextcloud/activity/blob/8481eb8aa8d688fd8127c7348f4dc6019cd8be5f/lib/ViewInfoCache.php#L143
• onreturn#526807944

So the problem seems to be in OC\Files\View->getPath($fileId)

[PVince81]

@icewind1991 do you remember what else we changed that could be related ?

[icewind1991]

No idea what could cause this and can't reproduce