Shadow for buttons looks strange and off-style

[jancborchardt]

Check this out @nextcloud/designers:

Especially on the upload button and the dropdowns it just looks a bit strange. We do not have 3D-like effects anywhere else really, except the shadows of the app and user menus.
And it separates the style even more from the one we have on the website which is definitely not something I want to do.

@skjnldsv I assume this was part of a recent SCSS overhaul? Could we keep backend changes and severe look changes separate? ;)

[jancborchardt]

Fix at #3204, please review

[ChristophWurst]

I don't think it looks that strange/bad :-)

[eppfel]

@skjnldsv I assume this was part of a recent SCSS overhaul? Could we keep backend changes and severe look changes separate? ;)

No, this was part of a separate discussion here: #3121 and the PR got in over the weekend pretty fast: #3187

And I feel because, we don't use 3D anywhere it works so good. Buttons need to be more prominent, so if we do not use shadows, I would like to find another option.

[jancborchardt]

Why do the buttons need to be more prominent? They are not the most important thing on the page. In the Mail app for example, or in Contacts, it just looks strange:

The »New contact« button is definitely too distracting with the shadow style. The prominent placement on the top left is already enough to establish it as the action. Having the 3d effect just makes it look extraordinarily out of place.

[eppfel]

I also felt it looked a bit weird and therefore I encouraged @skjnldsv to do an PR to see it more in context, but it was merged before it was properly reviewed.

Why do the buttons need to be more prominent?

The distinction between inputs and buttons was the shallow IMO. So for forms the 3D buttons work very well for me (see OP).

The »New contact« button is definitely too distracting with the shadow style.

Maybe this is an issue with buttons in the sidebar? See calendar for example:

[MariusBluem]

Maybe this is an issue with buttons in the sidebar? See calendar for example:

This is something introduced with #3150 and has nothing to do with the buttons, I think 😁 ... Good catch anyway ... Please open a new issue for that 🤔 @eppfel

[MariusBluem]

I want to add, that I ❤️ the 3D-Effect at the tags 😁 ... maybe there is a way to keep it 🤔 What do you think about that?

[eppfel]

This is something introduced with #3150 and has nothing to do with the buttons, I think 😁 ... Good catch anyway

I did not meant to show the highlight issue. I wanted to exemplify, that in the sidebar, we maybe do not need a "button" for the "new x" anyway.