Login button without border/color distinction after upgrading to 12.0.3

[Bubu]

Steps to reproduce

1. Use Nextcloud 12.0.3
2. Remove the Login Image inside the theming app
3. Use any theme color, or keep the default

Expected behaviour

Login button has a distinctive background like in any version before.

Actual behaviour

Login button has no border and no different background. It's really not a button anymore and you wouldn't guess it's clickable from the design.

#

[Tsuroerusu]

I am also experiencing this problem. To me it is actually a pretty large regression in the theming app, because I use a bit of branding for some of my customers, and it looks really unprofessional with the button seeming almost invisible because of the lack of a differentiating color.

[Tsuroerusu]

Another problem that this bug is causing is that with the default theming settings, the login button does not get its mouse-over effect.

[BrookeDot]

I'm new to Nextcloud but this almost feels like an esthetic thing to me and less like a bug. However, if the functionality itself has been changed from an earlier version I can see how that can feel like a bug and be something that may need fixing.

A few quick notes:

1. users can always press the enter key to login even if they don't see the login "button"
2. I use the custom CSS app and added a simple gradient background which is one way to make the button appear:

3) Apply a background image to the login page via login background.

Looks like this is the line where the colour is being applied and If it's determined this is a regression I think this could be a great first commit/patch as a way I can contribute to the project:
https://github.com/nextcloud/server/blob/master/apps/theming/css/theming.scss#L93

From the commit history I see @MorrisJobke changed things in f5aea79

Looks like the intention was to have a single boarder around the buttons but for them to match the background color of the login. See: #6370

If that's the case I'll work on getting a quick CSS patch.

[Tsuroerusu]

@BandonRandon In versions prior to 12.0.3 it would generate a colour lighter than the background colour for the login button.

Here's an example from one of my servers:

This is waaaay better, because you can an actual button, visually, and not what looks like just a link. I definitely think this is a regression, and I would really hope it could be fixed soon. For my theming it ruins things. Or at least have it be optional, so I could choose to have a varying colour for the login button (Which I suspect most people would want to do) or have it be the same as the background colour.

This is also really important for the Android and iOS apps. I connected one of my phones to Nextcloud just last night, and it would bring up the web interface for the login prompt, and for a touch interface, you need an indication of which area constitutes the button, and you get that by the variant colour, but for 12.0.3 and newer, you do not.

[MorrisJobke]

cc @nextcloud/theming

[MorrisJobke]

This was fixed in master with 2e6d1a3

[Tsuroerusu]

@MorrisJobke I just took a look at that commit which you describe, and I then proceeded to look at the theming.scss file in 12.0.3, but the code is the same as the changed code in master. Unless I am seeing something wrong, this was actually broken by that commit, and not fixed, or do you mean to say that this change was intentional, ie. to not show login button with a colour distinct from the page background?

[MorrisJobke]

Fix is in #7322