Invalid HTML markup for mentioned users in comments

[danxuliu]

User mentions contain a div element (the avatar) inside a span element (the wrapper for both avatar and user name) in the list of mention suggestions and in the mentions themselves.

I do not know if it would be better to show the avatar using a span or to change its parent span elements to div elements (which would require some CSS changes too); however, the contacts menu element, which is a div, is created inside the wrapper for both avatar and user name, so maybe the second alternative is better to also solve this markup problem.

@blizzz @jancborchardt

[pixelipo]

I think .avatar should be span in both cases - same as in core/js/share.js (line 210) In fact, semantically, it should be span even more than in the Files app because it is fully in-line content.

I'm not sure what to do about the popover, though 😞

Also, there is another parent span .atwho-inserted that looks like it should be removed or merged with the .avatar-name-wrapper

[blizzz]

Actually I copy-pasted 🙊 the avatar-formatting-HTML from somewhere else. Best would be to get this consolidated and reusable in one place. The div then can be transformed to span, I guess.

Also, there is another parent span .atwho-inserted that looks like it should be removed or merged with the .avatar-name-wrapper

That's from the Notification-Insertion lib, and is being auto-created. And it contains more than just the .avatar-name-wrapper, so leave it. UPDATE: ah, does not, but then it is auto-inserted anyhow, changing this adds more handling logic and potential to break.

[skjnldsv]

Not seeing this anymore.