-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed
Labels
Milestone
Description
I see it split in those sub tasks:
- 1. After posting a comment containing a valid username prepended by an @ (
@foobar) the user (if existing & having access to the file) gets a notification about a comment where he is mentioned. This does not happen when editing comments. (This was worked on in [WIP] notify user when mentioned in comments owncloud/core#24495)
PR at Notifications for simple @-mentioning in comments #1449 - 2. When presenting the comment, the client should replace the username with the corresponding display name. The web UI should do this at first. In edit mode, the
@usernameformat is used (for now).
PR at comment mentions: show displayname not uid #1738 - 3. When writing or editing a comment and typing an @ in the beginning of a word followed by another character an auto-complete is offered. It only includes users that have access to the file. Results are supposed to show up with a slight delay. For scaling reasons, it needs to be figured out whether all possible users are fetched in the background in advance, or on demand (like search dialog).
- 4. The comments API is extended so that the Comment instance also offers a list of username-displayname combinations for the users mentioned in it. The list is empty, if not user is mentioned. This allows the client to replace the
@usernamewithout looking up display names at the ownCloud server in seperate steps. I.e. the WebDAV resource returns this information just as well.
PR at comment mentions: show displayname not uid #1738
Further desired additions, might be out of scope for this stage:
- subscription system
- open sidebar and comments tab after clicking on notification, and …
- … also highlight the corresponding mention (cf. Notifications for simple @-mentioning in comments #1449 (comment))