PHP fatal error after running web updater

[despens]

Steps to reproduce

1. Use web updater to update to version 13.0.0

Expected behaviour

nextcloud should run after the update

Actual behaviour

PHP fatal error

Server configuration

Operating system:
Ubuntu 16.04

Web server:
Server version: Apache/2.4.18 (Ubuntu)
Server built: 2017-09-18T15:09:02

Database:
PostgreSQL 9.5.10

PHP version:
PHP 7.0.22-0ubuntu0.16.04.1 (cli) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
with Zend OPcache v7.0.22-0ubuntu0.16.04.1, Copyright (c) 1999-2017, by Zend Technologies

Nextcloud version: (see Nextcloud admin page)
13.0.0

Updated from an older Nextcloud/ownCloud or fresh install:
Updated

Where did you install Nextcloud from:
Web Updater

Signing status: n/a

List of activated apps:

App list

Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Enabled:
  - activity: 2.5.2
  - admin_audit: 1.2.0
  - apporder: 0.4.1
  - bruteforcesettings: 1.0.3
  - calendar: 1.5.7
  - checksum: 0.3.5
  - comments: 1.2.0
  - contacts: 2.0.1
  - dav: 1.3.1
  - external: 2.0.3
  - federatedfilesharing: 1.2.0
  - federation: 1.2.0
  - files: 1.7.2
  - files_accesscontrol: 1.2.5
  - files_automatedtagging: 1.2.2
  - files_clipboard: 0.7.1
  - files_downloadactivity: 1.1.1
  - files_external: 1.3.0
  - files_markdown: 2.0.1
  - files_sharing: 1.4.0
  - files_texteditor: 2.4.1
  - files_trashbin: 1.2.0
  - files_versions: 1.5.0
  - files_videoplayer: 1.1.0
  - firstrunwizard: 2.1
  - gallery: 17.0.0
  - groupfolders: 1.2.0
  - issuetemplate: 0.3.0
  - logreader: 2.0.0
  - lookup_server_connector: 1.0.0
  - nextcloud_announcements: 1.1
  - notes: 2.3.2
  - notifications: 2.0.0
  - oauth2: 1.0.5
  - password_policy: 1.2.2
  - previewgenerator: 1.0.9
  - provisioning_api: 1.2.0
  - serverinfo: 1.2.0
  - sharebymail: 1.2.0
  - spreed: 2.0.2
  - survey_client: 1.0.0
  - systemtags: 1.2.0
  - tasks: 0.9.6
  - theming: 1.3.0
  - twofactor_backupcodes: 1.1.1
  - updatenotification: 1.2.0
  - user_external: 0.4
  - workflowengine: 1.2.0
Disabled:
  - announcementcenter
  - deck
  - direct_menu
  - documents
  - encryption
  - files_pdfviewer
  - lsd
  - user_ldap

Nextcloud configuration:

Config report

Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "12.0.5.3",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mail_smtpmode": "sendmail",
        "forcessl": true,
        "loglevel": 0,
        "overwrite.cli.url": 1,
        "theme": "",
        "maintenance": false,
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "blacklisted_files": [],
        "secret": "***REMOVED SENSITIVE VALUE***",
        "preview_max_scale_factor": 1,
        "enabledPreviewProviders": [
            "OC\\Preview\\Image",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\PDF",
            "OC\\Preview\\SVG",
            "OC\\Preview\\Movie",
            "OC\\Preview\\MSOffice2003",
            "OC\\Preview\\MSOffice2007",
            "OC\\Preview\\MSOfficeDoc",
            "OC\\Preview\\Illustrator",
            "OC\\Preview\\Photoshop",
            "OC\\Preview\\TIFF"
        ],
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "trashbin_retention_obligation": "auto",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "htaccess.RewriteBase": "\/",
        "appstore.experimental.enabled": true,
        "updater.release.channel": "stable",
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: nish

Logs

Web server error log

Web server error log

[Sat Feb 10 08:47:46.640375 2018] [:error] [pid 21172] [client XXX.XXX.XXX.XXX:35614] PHP Fatal error:  Declaration of OCA\\FilesAccessControl\\StorageWrapper::copyFromStorage(OCP\\Files\\Storage $sourceStorage, $sourceInternalPath, $targetInternalPath) must be compatible with OCP\\Files\\Storage::copyFromStorage(OCP\\Files\\Storage\\IStorage $sourceStorage, $sourceInternalPath, $targetInternalPath) in /var/www/nextcloud/apps/files_accesscontrol/lib/StorageWrapper.php on line 628

[despens]

After following instructions here the update completed. Since I updated from the stable channel, I wasn't expecting something like this to happen.

[MorrisJobke]

After following instructions here the update completed. Since I updated from the stable channel, I wasn't expecting something like this to happen.

@nickvergessen Is there a way to disable an app before the updater get's called? I don't think so, right? And what about shipping an update of the files_access_control app via app store to stable12 and state that this needs to be done before.

[MorrisJobke]

See also #7439 and #7532 - it is only fixed in the 13 version of the app :/ nextcloud/files_accesscontrol#75

So sadly there is not much we can do here :/ sorry for the mess.

@jospoortvliet Any way to put this also in the release notes?

[nickvergessen]

Yeah, no idea. We need to remember which apps were disabled by the updater and check for their updates manually later on.
I will try to have a look.