Fix undeclared method warning in phan #10080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MorrisJobke
commented
Jul 2, 2018
MorrisJobke
commented
- from Systemd Logger #10048
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Merged
nickvergessen
approved these changes
Jul 2, 2018
icewind1991
approved these changes
Jul 2, 2018
Member
|
@MorrisJobke it was not failing there? Phan got a new build with php-systemd enabled so this should not be necessary at all. |
Member
Author
See #10079 |
Member
|
@MorrisJobke it was running successfully in https://drone.nextcloud.com/nextcloud/server/8583/252 however. Where does drone take the config from? The feature branch or the target branch? If feature, a rebase would have helped. |
Member
Author
|
Let me then revert this and see if this still works ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.