prevent lock values from going negative with memcache backend #10116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be caused by the code releasing more locks then it acquires, once the lock value becomes negative it's likely that it will never be able to change into an exclusive lock again. Signed-off-by: Robin Appelman <robin@icewind.nl>
Member
|
Will this fix old locked files as well? |
Member
Author
|
If a shared lock is acquired and released for an existing broken file it should fix itself. |
Member
MorrisJobke
approved these changes
Jul 6, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code makes sense and it still works fine 👍
This was referenced Jul 6, 2018
nickvergessen
approved these changes
Jul 6, 2018
Member
|
The failing tests are unrelated -> merging. |
Member
|
Backport to stable13 makes sense IMO. |
Member
|
@icewind1991 We should do the same for the DB provider as I have seen a stak trace with "-1" in the SQL query as well: #9305 (comment) |
Member
Author
|
The db locking backend uses |
Member
|
@icewind1991 Mind to open backport PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be caused by the code releasing more locks then it acquires,
once the lock value becomes negative it's likely that it will never be able
to change into an exclusive lock again.
Signed-off-by: Robin Appelman robin@icewind.nl