Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 12, 2018

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good 👍

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Invitation table is also too long

@georgehrke
Copy link
Member

What's the exact limit that oracle enforces?

@MorrisJobke
Copy link
Member

What's the exact limit that oracle enforces?

32 AFAIK, but you need to mind the prefix ;)

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MorrisJobke MorrisJobke merged commit 09d5b61 into master Jul 12, 2018
@MorrisJobke MorrisJobke deleted the bugfix/noid/shorten-resource-table-names-to-allow-install-on-oracle branch July 12, 2018 10:30
@nickvergessen
Copy link
Member Author

i will write a checker for this

@nickvergessen
Copy link
Member Author

https://travis-ci.org/nextcloud/notifications/builds/403051765 passing with this branch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants